[Discover] Migrate expandedDoc to internalStateContainer #153369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
added
the
Team:DataDiscovery
kertal
added
Feature:Discover
kertal
commented
Mar 21, 2023
| @@ -37,7 +36,6 @@ export function DiscoverMainApp(props: DiscoverMainProps) { | |||
| const services = useDiscoverServices(); | |||
| const { chrome, docLinks, data, spaces, history } = services; | |||
| const usedHistory = useHistory(); | |||
| const [expandedDoc, setExpandedDoc] = useState<DataTableRecord | undefined>(undefined); | |||
There was a problem hiding this comment.
this is the main change, removal of expandedDoc high up in the component tree
To DiscoverAppState / DiscoverDataStateContainer
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @kertal |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
jughosta
approved these changes
Mar 22, 2023
kibanamachine
added
v8.8.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the stateful
expandedDocproperty (It determines which ES document should be displayed in the flyout showing he doc viewer, and needs to be closed when e.g. the inspector is displayed) to theinternalStateContainer, one lessuseStatebased prop left that needs to be passed down the component tree.Additionally
AppStateis renamed toDiscoverAppState,DataStateContainertoDiscoverDataStateContainerandInternalStateContainertoDiscoverInternalStateContainerfor better consistency of naming and easier autocompletion when developingChecklist