Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter guided onboarding solutions based on cloud discovery questions… #153367

Merged
merged 6 commits into from
Apr 4, 2023
Merged

Filter guided onboarding solutions based on cloud discovery questions… #153367

merged 6 commits into from
Apr 4, 2023

Conversation

claracruz
Copy link
Contributor

@claracruz claracruz commented Mar 21, 2023 •
edited by alisonelizabeth
Loading

Related to #148911

This PR updates the guided onboarding landing page to filter solutions based on user selected use case in cloud discovery questions. The value will be passed as querystring parameter ?cloudDiscoveryUseCase=[value] from Cloud UI.

@claracruz claracruz added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Journey/Onboarding Platform Journey Onboarding team v8.8.0 labels Mar 21, 2023
@claracruz claracruz requested a review from a team as a code owner March 21, 2023 13:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

alisonelizabeth
alisonelizabeth reviewed Mar 22, 2023
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. Verified locally.

I had one suggestion: What do you think about automatically updating the query param if a user changes the filter? i.e., A user might select "Search" from the discovery questions, but then on the landing page in Kibana change the filter to "Observability". As it is now, if they refresh the page, they would end up back with the "Search" filter rather than "Observability".

src/plugins/home/public/application/components/guided_onboarding/getting_started.tsx Outdated Show resolved Hide resolved
@claracruz claracruz force-pushed the guided_onboarding/8.8/filter_solutions_based_on_discovery_questions branch 2 times, most recently from ab55231 to 8bff1d1 Compare March 28, 2023 16:23
alisonelizabeth
alisonelizabeth approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest LGTM. Great work @claracruz 🎉

I left a few comments in the code, if you can take a look. Mostly nits, so I'm going to go ahead and approve. Let me know what you think.

src/plugins/home/public/application/components/guided_onboarding/getting_started.tsx Outdated Show resolved Hide resolved
src/plugins/home/public/application/components/guided_onboarding/getting_started.tsx Outdated Show resolved Hide resolved
packages/kbn-guided-onboarding/src/components/landing_page/guide_filters.tsx Outdated Show resolved Hide resolved
@claracruz claracruz force-pushed the guided_onboarding/8.8/filter_solutions_based_on_discovery_questions branch from 8bff1d1 to be3609a Compare April 3, 2023 15:48
@claracruz
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
home 197 201 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
home 153.9KB 159.5KB +5.6KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/guided-onboarding 2 3 +1
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@claracruz claracruz merged commit cb3a42a into elastic:main Apr 4, 2023
@alisonelizabeth alisonelizabeth mentioned this pull request Apr 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Journey/Onboarding Platform Journey Onboarding team v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@claracruz @elasticmachine @kibana-ci @alisonelizabeth @kibanamachine