-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to v76.3.0
#153341
Upgrade EUI to v76.3.0
#153341
Conversation
Pinging @elastic/eui-design (EUI) |
Pinging @elastic/uptime (Team:uptime) |
Pinging @elastic/apm-ui (Team:APM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Synthetics changes LGTM 👍
@@ -37,7 +37,9 @@ describe('SelectSeverity', () => { | |||
); | |||
|
|||
// assert initial state | |||
expect(getAllByText('warning')).toHaveLength(2); | |||
// EuiSuperSelect was refactored to update SR-only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion to remove this comment in the code before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qn895 Sure thing. I'll remove this and merge. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I accidentally bumped your PR comment to a re-review. I've updated the test and CI is building again.
ML changes LGTM 🎉 |
💔 Build FailedFailed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @1Copenut |
## Summary [email protected] ⏩ [email protected] ## [`76.3.0`](https://github.com/elastic/eui/tree/v76.3.0) - Updated `EuiSkipLink`'s `fallbackDestination` prop to support an array of query selector strings ([elastic#6646](elastic/eui#6646)) **Bug fixes** - Fixed `EuiFlyout` to preserve body scrollbar width on open ([elastic#6645](elastic/eui#6645)) - Fixed `EuiImage`'s full screen mode to not scroll jump & to preserve body scrollbar width on open ([elastic#6645](elastic/eui#6645)) - Fixed `EuiCodeBlock`'s full screen mode to not scroll jump & to preserve body scrollbar width on open ([elastic#6645](elastic/eui#6645)) ## [`76.2.0`](https://github.com/elastic/eui/tree/v76.2.0) - Added new `renderCustomGridBody` escape hatch rendering prop to `EuiDataGrid` ([elastic#6624](elastic/eui#6624)) **Bug fixes** - Fixed visual listbox focus ring bug on non-searchable `EuiSelectable`s ([elastic#6637](elastic/eui#6637)) - Added a legacy `alert` alias for the `warning` `EuiIcon` type ([elastic#6640](elastic/eui#6640)) - Fixed a type definition incorrectly coming from a dev dependency, which was causing issues for some consuming projects ([elastic#6643](elastic/eui#6643)) ## [`76.1.0`](https://github.com/elastic/eui/tree/v76.1.0) - Added more detailed screen reader instructions to `EuiSelectable`, `EuiSuggest`, `EuiSelectableTemplateSitewide`, `EuiRange`, and `EuiDualRange`. ([elastic#6589](elastic/eui#6589)) - Added new `placeholder` prop to `EuiSuperSelect` ([elastic#6630](elastic/eui#6630)) - Added new `setCellPopoverProps` parameter callback to `EuiDataGrid`'s `renderCellPopover` prop ([elastic#6632](elastic/eui#6632)) **Bug fixes** - Fixed an ARIA attribute in `EuiSelectableList` ([elastic#6589](elastic/eui#6589)) - Fixed `EuiSelectable` to no longer show active selection state or respond to the Up/Down arrow keys when focus is inside the selectable container, but not on the searchbox or listbox. ([elastic#6631](elastic/eui#6631)) --------- Co-authored-by: Tiago Costa <[email protected]>
Summary
[email protected] ⏩ [email protected]
76.3.0
EuiSkipLink
'sfallbackDestination
prop to support an array of query selector strings (#6646)Bug fixes
EuiFlyout
to preserve body scrollbar width on open (#6645)EuiImage
's full screen mode to not scroll jump & to preserve body scrollbar width on open (#6645)EuiCodeBlock
's full screen mode to not scroll jump & to preserve body scrollbar width on open (#6645)76.2.0
renderCustomGridBody
escape hatch rendering prop toEuiDataGrid
(#6624)Bug fixes
EuiSelectable
s (#6637)alert
alias for thewarning
EuiIcon
type (#6640)76.1.0
EuiSelectable
,EuiSuggest
,EuiSelectableTemplateSitewide
,EuiRange
, andEuiDualRange
. (#6589)placeholder
prop toEuiSuperSelect
(#6630)setCellPopoverProps
parameter callback toEuiDataGrid
'srenderCellPopover
prop (#6632)Bug fixes
EuiSelectableList
(#6589)EuiSelectable
to no longer show active selection state or respond to the Up/Down arrow keys when focus is inside the selectable container, but not on the searchbox or listbox. (#6631)