Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v76.3.0 #153341

Merged
merged 14 commits into from
Mar 23, 2023
Merged

Upgrade EUI to v76.3.0 #153341

merged 14 commits into from
Mar 23, 2023

Conversation

1Copenut
Copy link
Contributor

@1Copenut 1Copenut commented Mar 20, 2023

Summary

[email protected][email protected]

76.3.0

  • Updated EuiSkipLink's fallbackDestination prop to support an array of query selector strings (#6646)

Bug fixes

  • Fixed EuiFlyout to preserve body scrollbar width on open (#6645)
  • Fixed EuiImage's full screen mode to not scroll jump & to preserve body scrollbar width on open (#6645)
  • Fixed EuiCodeBlock's full screen mode to not scroll jump & to preserve body scrollbar width on open (#6645)

76.2.0

  • Added new renderCustomGridBody escape hatch rendering prop to EuiDataGrid (#6624)

Bug fixes

  • Fixed visual listbox focus ring bug on non-searchable EuiSelectables (#6637)
  • Added a legacy alert alias for the warning EuiIcon type (#6640)
  • Fixed a type definition incorrectly coming from a dev dependency, which was causing issues for some consuming projects (#6643)

76.1.0

  • Added more detailed screen reader instructions to EuiSelectable, EuiSuggest, EuiSelectableTemplateSitewide, EuiRange, and EuiDualRange. (#6589)
  • Added new placeholder prop to EuiSuperSelect (#6630)
  • Added new setCellPopoverProps parameter callback to EuiDataGrid's renderCellPopover prop (#6632)

Bug fixes

  • Fixed an ARIA attribute in EuiSelectableList (#6589)
  • Fixed EuiSelectable to no longer show active selection state or respond to the Up/Down arrow keys when focus is inside the selectable container, but not on the searchbox or listbox. (#6631)

@1Copenut 1Copenut added EUI backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment v8.8.0 labels Mar 20, 2023
@1Copenut 1Copenut self-assigned this Mar 20, 2023
@1Copenut 1Copenut changed the title Upgrade EUI to v76.2.0 Upgrade EUI to v76.3.0 Mar 21, 2023
@1Copenut 1Copenut marked this pull request as ready for review March 22, 2023 14:50
@1Copenut 1Copenut requested review from a team as code owners March 22, 2023 14:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

@1Copenut 1Copenut added the release_note:skip Skip the PR/issue when compiling release notes label Mar 22, 2023
@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Mar 22, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synthetics changes LGTM 👍

@1Copenut 1Copenut requested a review from a team as a code owner March 23, 2023 18:20
@@ -37,7 +37,9 @@ describe('SelectSeverity', () => {
);

// assert initial state
expect(getAllByText('warning')).toHaveLength(2);
// EuiSuperSelect was refactored to update SR-only
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to remove this comment in the code before merging

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qn895 Sure thing. I'll remove this and merge. Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I accidentally bumped your PR comment to a re-review. I've updated the test and CI is building again.

@1Copenut 1Copenut requested a review from qn895 March 23, 2023 20:24
@qn895
Copy link
Member

qn895 commented Mar 23, 2023

ML changes LGTM 🎉

@1Copenut 1Copenut enabled auto-merge (squash) March 23, 2023 20:30
@kibana-ci
Copy link
Collaborator

kibana-ci commented Mar 23, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fileUpload 207 205 -2
maps 971 969 -2
total -4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fileUpload 853.4KB 852.8KB -609.0B
maps 2.7MB 2.7MB -610.0B
total -1.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 351.1KB 351.7KB +633.0B
kbnUiSharedDeps-css 314.9KB 315.6KB +655.0B
kbnUiSharedDeps-npmDll 5.4MB 5.4MB +8.0KB
total +9.2KB
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @1Copenut

@1Copenut 1Copenut merged commit 6d55dd9 into elastic:main Mar 23, 2023
jennypavlova pushed a commit to jennypavlova/kibana that referenced this pull request Mar 24, 2023
## Summary

[email protected][email protected]

## [`76.3.0`](https://github.com/elastic/eui/tree/v76.3.0)

- Updated `EuiSkipLink`'s `fallbackDestination` prop to support an array
of query selector strings
([elastic#6646](elastic/eui#6646))

**Bug fixes**

- Fixed `EuiFlyout` to preserve body scrollbar width on open
([elastic#6645](elastic/eui#6645))
- Fixed `EuiImage`'s full screen mode to not scroll jump & to preserve
body scrollbar width on open
([elastic#6645](elastic/eui#6645))
- Fixed `EuiCodeBlock`'s full screen mode to not scroll jump & to
preserve body scrollbar width on open
([elastic#6645](elastic/eui#6645))

## [`76.2.0`](https://github.com/elastic/eui/tree/v76.2.0)

- Added new `renderCustomGridBody` escape hatch rendering prop to
`EuiDataGrid` ([elastic#6624](elastic/eui#6624))

**Bug fixes**

- Fixed visual listbox focus ring bug on non-searchable `EuiSelectable`s
([elastic#6637](elastic/eui#6637))
- Added a legacy `alert` alias for the `warning` `EuiIcon` type
([elastic#6640](elastic/eui#6640))
- Fixed a type definition incorrectly coming from a dev dependency,
which was causing issues for some consuming projects
([elastic#6643](elastic/eui#6643))

## [`76.1.0`](https://github.com/elastic/eui/tree/v76.1.0)

- Added more detailed screen reader instructions to `EuiSelectable`,
`EuiSuggest`, `EuiSelectableTemplateSitewide`, `EuiRange`, and
`EuiDualRange`. ([elastic#6589](elastic/eui#6589))
- Added new `placeholder` prop to `EuiSuperSelect`
([elastic#6630](elastic/eui#6630))
- Added new `setCellPopoverProps` parameter callback to `EuiDataGrid`'s
`renderCellPopover` prop
([elastic#6632](elastic/eui#6632))

**Bug fixes**

- Fixed an ARIA attribute in `EuiSelectableList`
([elastic#6589](elastic/eui#6589))
- Fixed `EuiSelectable` to no longer show active selection state or
respond to the Up/Down arrow keys when focus is inside the selectable
container, but not on the searchbox or listbox.
([elastic#6631](elastic/eui#6631))

---------

Co-authored-by: Tiago Costa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment EUI release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants