Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Remove TS optimization scripts #153161

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

dgieselaar
Copy link
Member

The optimisation scripts that we had are no longer useful - they don't work w/ the command line type check, it's not easy to fix and there is no longer much of a difference in editor performance AFAICT. This also repairs the precommit script we have.

@dgieselaar dgieselaar added Team:APM All issues that need APM UI Team support v8.8.0 labels Mar 12, 2023
@dgieselaar dgieselaar requested review from a team as code owners March 12, 2023 10:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@dgieselaar
Copy link
Member Author

@elasticmachine merge upstream

@dgieselaar
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
apm 13 11 -2

ESLint disabled line counts

id before after diff
apm 73 71 -2
securitySolution 433 436 +3
total +1

Total ESLint disabled count

id before after diff
apm 86 82 -4
securitySolution 513 516 +3
total -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar added the release_note:skip Skip the PR/issue when compiling release notes label Mar 16, 2023
@dgieselaar dgieselaar merged commit 4fc365a into elastic:main Mar 16, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants