-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Do not match time series counter fields with aggs in wizards #153021
[ML] Do not match time series counter fields with aggs in wizards #153021
Conversation
Pinging @elastic/ml-ui (:ml) |
x-pack/plugins/ml/server/models/job_service/new_job_caps/field_service.ts
Outdated
Show resolved
Hide resolved
It might be possible to do something better than this for 8.8. elastic/elasticsearch#93884 is adding a list of supported aggregations. There's a CCS complication but a suggestion of how to deal with that in elastic/elasticsearch#93884 (comment). Depending on the resolution of the CCS issue we should do one of the following:
|
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM.
As @droberts195 suggested, once elastic/elasticsearch#93884 is in, we should look to show these field types and check the available aggregations.
Time series counter metric fields are treated as non aggregatable and are not matched with aggregations in the
new_job_caps
endpoint.This removes them from the detector dropdowns in all wizards where we match functions(aggs) to fields.
e.g.
Note, the fields are not entirely removed from the
new_job_caps
response. So they are still available in other dropdowns.This fixes an issue where having counter fields available for selection would cause an error.