Only log deprecation warnings for calls to Saved Objects routes from non-kibana request #152971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
release_note:skip
TinaHeiligers
added
the
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
pgayvallet
approved these changes
Mar 9, 2023
| @@ -152,3 +153,27 @@ export interface BulkGetItem { | |||
| fields?: string[]; | |||
| namespaces?: string[]; | |||
| } | |||
|
|
|||
| export function getIsKibanaRequest({ headers }: KibanaRequest) { | |||
There was a problem hiding this comment.
NIT: getIsKibanaRequest -> isKibanaRequest
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
TinaHeiligers
added a commit
to TinaHeiligers/kibana
that referenced
this pull request
Mar 9, 2023
…non-kibana request (elastic#152971) Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit e37e834) # Conflicts: # packages/core/saved-objects/core-saved-objects-server-internal/src/routes/index.ts # packages/core/saved-objects/core-saved-objects-server-internal/src/routes/utils.ts # packages/core/saved-objects/core-saved-objects-server-internal/tsconfig.json
TinaHeiligers
added a commit
that referenced
this pull request
Mar 9, 2023
… from non-kibana request (#152971) (#153053) # Backport This will backport the following commits from `main` to `8.7`: - [Only log deprecation warnings for calls to Saved Objects routes from non-kibana request (#152971)](#152971) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Christiane (Tina) Heiligers","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-09T17:23:21Z","message":"Only log deprecation warnings for calls to Saved Objects routes from non-kibana request (#152971)\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"e37e83428abe9bb8971419672969bcaa9db9918e","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Feature:Saved Objects","release_note:skip","backport:prev-minor","v8.8.0"],"number":152971,"url":"https://github.com/elastic/kibana/pull/152971","mergeCommit":{"message":"Only log deprecation warnings for calls to Saved Objects routes from non-kibana request (#152971)\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"e37e83428abe9bb8971419672969bcaa9db9918e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152971","number":152971,"mergeCommit":{"message":"Only log deprecation warnings for calls to Saved Objects routes from non-kibana request (#152971)\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"e37e83428abe9bb8971419672969bcaa9db9918e"}}]}] BACKPORT-->
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
…non-kibana request (elastic#152971) Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #150775
The logs are generated every time a deprecated route is called and we have extensive use of these routes throughout Kibana.
Since customers can't do anything about the Kibana UI using the saved objects client, logging these warnings so many times may lead to turning off logging completely.
This PR improves that, only logging when a request is external to Kibana.
Risk Matrix