Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Adding file telemetry #152968

Merged
merged 8 commits into from
Mar 24, 2023
Merged

[Cases] Adding file telemetry #152968

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8268027
Adding telemetry changes
jonathan-buttner Mar 8, 2023
89229fa
Adding telemetry for all cases
jonathan-buttner Mar 9, 2023
913070c
Merge branch 'main' of github.com:elastic/kibana into cases-files-tel…
jonathan-buttner Mar 9, 2023
960e3dd
Fixing type errors
jonathan-buttner Mar 9, 2023
c12d75a
Forgot type
jonathan-buttner Mar 9, 2023
73c89da
Fixing telemetry mapping errors
jonathan-buttner Mar 9, 2023
a6bbf17
Fixing schema failures from null
jonathan-buttner Mar 9, 2023
5a992b7
Merge branch 'main' into cases-files-telemetry
jonathan-buttner Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions x-pack/plugins/cases/server/telemetry/constants.ts
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion x-pack/plugins/cases/server/telemetry/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import type {
import { SavedObjectsErrorHelpers } from '@kbn/core/server';
import type { TaskManagerSetupContract } from '@kbn/task-manager-plugin/server';
import type { UsageCollectionSetup } from '@kbn/usage-collection-plugin/server';
import { FILE_SO_TYPE } from '@kbn/files-plugin/common';
import { collectTelemetryData } from './collect_telemetry_data';
import {
CASE_TELEMETRY_SAVED_OBJECT,
Expand Down Expand Up @@ -42,7 +43,7 @@ export const createCasesTelemetry = async ({
}: CreateCasesTelemetryArgs) => {
const getInternalSavedObjectClient = async (): Promise<ISavedObjectsRepository> => {
const [coreStart] = await core.getStartServices();
return coreStart.savedObjects.createInternalRepository(SAVED_OBJECT_TYPES);
return coreStart.savedObjects.createInternalRepository([...SAVED_OBJECT_TYPES, FILE_SO_TYPE]);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just calling this out, to retrieve the average file size we have to do an average aggregation over the file service's saved objects that contain a metadata field caseId. Hopefully it's ok that we're accessing the file service's saved object internals.

The advantage of doing it this way is that we don't need to duplicate the file size within case comments.

};

taskManager.registerTaskDefinitions({
Expand Down
Loading