Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech Debt] Reorder SLO List page #152903

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

CoenWarmer
Copy link
Contributor

Resolves #152793

Summary

This PR updates the SLO List Page to follow the newly agreed upon structure for the Observability app.

This PR is part of a larger effort to have all pages in the Observability app follow the same structure so they are more consistent with each other. More details in the epic: #152783

It also cleans up dead and unused components where found.

All design and functionality should be exactly the same as before.

@CoenWarmer CoenWarmer requested a review from a team as a code owner March 8, 2023 12:55
@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label Mar 8, 2023
@CoenWarmer CoenWarmer force-pushed the chore/152793-reorder-slo-page branch from ecacc98 to 0fd680a Compare March 8, 2023 13:09
@CoenWarmer CoenWarmer force-pushed the chore/152793-reorder-slo-page branch from 0fd680a to 7619245 Compare March 9, 2023 09:09
@CoenWarmer CoenWarmer requested a review from a team as a code owner March 9, 2023 09:09
@CoenWarmer CoenWarmer removed the request for review from a team March 9, 2023 09:11
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer merged commit 4e55567 into elastic:main Mar 16, 2023
@CoenWarmer CoenWarmer deleted the chore/152793-reorder-slo-page branch March 16, 2023 14:03
@kibanamachine kibanamachine added v8.8.0 backport:skip This commit does not require backporting labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust folder structure in SLO List page
4 participants