-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tech Debt] Reorder Rule Details page #152902
Closed
CoenWarmer
wants to merge
24
commits into
elastic:main
from
CoenWarmer:chore/152791-reorder-rule-detail-page
Closed
[Tech Debt] Reorder Rule Details page #152902
CoenWarmer
wants to merge
24
commits into
elastic:main
from
CoenWarmer:chore/152791-reorder-rule-detail-page
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoenWarmer
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Mar 8, 2023
Investigating why the bundle increased so much with this PR. |
CoenWarmer
force-pushed
the
chore/152791-reorder-rule-detail-page
branch
from
March 16, 2023 16:16
eaa0056
to
f413b3d
Compare
…order-rule-detail-page
CoenWarmer
force-pushed
the
chore/152791-reorder-rule-detail-page
branch
from
March 16, 2023 16:18
f413b3d
to
5e83992
Compare
…order-rule-detail-page m
CoenWarmer
force-pushed
the
chore/152791-reorder-rule-detail-page
branch
from
March 17, 2023 03:28
14df607
to
9cb2050
Compare
…order-rule-detail-page
CoenWarmer
force-pushed
the
chore/152791-reorder-rule-detail-page
branch
2 times, most recently
from
April 17, 2023 16:46
698eac8
to
9a3dd3d
Compare
CoenWarmer
force-pushed
the
chore/152791-reorder-rule-detail-page
branch
from
April 17, 2023 16:48
9a3dd3d
to
9f89a90
Compare
…enWarmer/kibana into chore/152791-reorder-rule-detail-page
CoenWarmer
force-pushed
the
chore/152791-reorder-rule-detail-page
branch
2 times, most recently
from
April 18, 2023 09:43
7289567
to
8ac5cae
Compare
CoenWarmer
force-pushed
the
chore/152791-reorder-rule-detail-page
branch
2 times, most recently
from
April 18, 2023 09:54
8fc88bc
to
ffa8b96
Compare
CoenWarmer
force-pushed
the
chore/152791-reorder-rule-detail-page
branch
from
April 18, 2023 10:30
ffa8b96
to
4264447
Compare
…order-rule-detail-page
…order-rule-detail-page
…order-rule-detail-page
…enWarmer/kibana into chore/152791-reorder-rule-detail-page
…order-rule-detail-page
…order-rule-detail-page
💔 Build FailedFailed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #152791
Summary
This PR updates the Rule Detail Page to follow the newly agreed upon structure for the Observability app.
This PR is part of a larger effort to have all pages in the Observability app follow the same structure so they are more consistent with each other. More details in the epic: #152783
It also cleans up dead and unused components where found.
All design and functionality should be exactly the same as before.