Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech Debt] Reorder Rule Details page #152902

Closed

Conversation

CoenWarmer
Copy link
Contributor

Resolves #152791

Summary

This PR updates the Rule Detail Page to follow the newly agreed upon structure for the Observability app.

This PR is part of a larger effort to have all pages in the Observability app follow the same structure so they are more consistent with each other. More details in the epic: #152783

It also cleans up dead and unused components where found.

All design and functionality should be exactly the same as before.

@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label Mar 8, 2023
@CoenWarmer CoenWarmer marked this pull request as ready for review March 8, 2023 14:46
@CoenWarmer CoenWarmer requested review from a team as code owners March 8, 2023 14:47
@CoenWarmer
Copy link
Contributor Author

Investigating why the bundle increased so much with this PR.

@CoenWarmer CoenWarmer marked this pull request as draft March 9, 2023 09:58
@CoenWarmer CoenWarmer force-pushed the chore/152791-reorder-rule-detail-page branch from eaa0056 to f413b3d Compare March 16, 2023 16:16
@CoenWarmer CoenWarmer force-pushed the chore/152791-reorder-rule-detail-page branch from f413b3d to 5e83992 Compare March 16, 2023 16:18
@CoenWarmer CoenWarmer removed the request for review from a team March 16, 2023 17:25
@CoenWarmer CoenWarmer force-pushed the chore/152791-reorder-rule-detail-page branch from 14df607 to 9cb2050 Compare March 17, 2023 03:28
@CoenWarmer CoenWarmer force-pushed the chore/152791-reorder-rule-detail-page branch 2 times, most recently from 698eac8 to 9a3dd3d Compare April 17, 2023 16:46
@CoenWarmer CoenWarmer force-pushed the chore/152791-reorder-rule-detail-page branch from 9a3dd3d to 9f89a90 Compare April 17, 2023 16:48
@CoenWarmer CoenWarmer force-pushed the chore/152791-reorder-rule-detail-page branch 2 times, most recently from 7289567 to 8ac5cae Compare April 18, 2023 09:43
@CoenWarmer CoenWarmer force-pushed the chore/152791-reorder-rule-detail-page branch 2 times, most recently from 8fc88bc to ffa8b96 Compare April 18, 2023 09:54
@CoenWarmer CoenWarmer force-pushed the chore/152791-reorder-rule-detail-page branch from ffa8b96 to 4264447 Compare April 18, 2023 10:30
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 20, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 434 437 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.0MB 1002.8KB -21.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 86.0KB 103.9KB +17.9KB
Unknown metric groups

async chunk count

id before after diff
observability 11 10 -1

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 411 415 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 494 498 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer closed this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust folder structure in Rule Detail page
3 participants