[Kibana migrator test kit] Flush logger after running migrations #152818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsoldevila
added
bug
|
Pinging @elastic/kibana-core (Team:Core) |
…-ref HEAD~1..HEAD --fix'
gsoldevila
changed the title
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
gsoldevila
added a commit
to gsoldevila/kibana
that referenced
this pull request
Mar 8, 2023
…stic#152818) This PR addresses flakiness of: - elastic#152472 - elastic#152448 These tests fail because we have a race condition. We are checking certain conditions in the log files, and sometimes we do it before the logs are actually written. With the Kibana migrator test kit, we can actually flush + wait for all the logging appenders. This way, we are sure that the logs are complete when we inspect them in the tests. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 163dae7)
gsoldevila
added a commit
that referenced
this pull request
Mar 8, 2023
#152818) (#152890) # Backport This will backport the following commits from `main` to `8.7`: - [[Kibana migrator test kit] Flush logger after running migrations (#152818)](#152818) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-07T17:57:17Z","message":"[Kibana migrator test kit] Flush logger after running migrations (#152818)\n\nThis PR addresses flakiness of:\r\n\r\n- https://github.com/elastic/kibana/issues/152472\r\n- https://github.com/elastic/kibana/issues/152448\r\n\r\nThese tests fail because we have a race condition. We are checking\r\ncertain conditions in the log files, and sometimes we do it before the\r\nlogs are actually written.\r\n\r\nWith the Kibana migrator test kit, we can actually flush + wait for all\r\nthe logging appenders. This way, we are sure that the logs are complete\r\nwhen we inspect them in the tests.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"163dae7154c11d92ff148bc6ac45cbea54680769","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Core","release_note:skip","test-failure-flaky","Feature:Migrations","backport:prev-minor","v8.7.0","v8.8.0"],"number":152818,"url":"https://github.com/elastic/kibana/pull/152818","mergeCommit":{"message":"[Kibana migrator test kit] Flush logger after running migrations (#152818)\n\nThis PR addresses flakiness of:\r\n\r\n- https://github.com/elastic/kibana/issues/152472\r\n- https://github.com/elastic/kibana/issues/152448\r\n\r\nThese tests fail because we have a race condition. We are checking\r\ncertain conditions in the log files, and sometimes we do it before the\r\nlogs are actually written.\r\n\r\nWith the Kibana migrator test kit, we can actually flush + wait for all\r\nthe logging appenders. This way, we are sure that the logs are complete\r\nwhen we inspect them in the tests.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"163dae7154c11d92ff148bc6ac45cbea54680769"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152818","number":152818,"mergeCommit":{"message":"[Kibana migrator test kit] Flush logger after running migrations (#152818)\n\nThis PR addresses flakiness of:\r\n\r\n- https://github.com/elastic/kibana/issues/152472\r\n- https://github.com/elastic/kibana/issues/152448\r\n\r\nThese tests fail because we have a race condition. We are checking\r\ncertain conditions in the log files, and sometimes we do it before the\r\nlogs are actually written.\r\n\r\nWith the Kibana migrator test kit, we can actually flush + wait for all\r\nthe logging appenders. This way, we are sure that the logs are complete\r\nwhen we inspect them in the tests.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"163dae7154c11d92ff148bc6ac45cbea54680769"}}]}] BACKPORT-->
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
…stic#152818) This PR addresses flakiness of: - elastic#152472 - elastic#152448 These tests fail because we have a race condition. We are checking certain conditions in the log files, and sometimes we do it before the logs are actually written. With the Kibana migrator test kit, we can actually flush + wait for all the logging appenders. This way, we are sure that the logs are complete when we inspect them in the tests. --------- Co-authored-by: kibanamachine <[email protected]>
mistic
pushed a commit
that referenced
this pull request
Mar 22, 2023
Fixes flakiness on: * #152448 * #152472 And also related PR builds failures, e.g. #153332 ([failure](https://s3.amazonaws.com/buildkiteartifacts.com/e0f3970e-3a75-4621-919f-e6c773e2bb12/0fda5127-f57f-42fb-8e5a-146b3d535916/018705a0-a7cc-422a-89a3-026a2637b9e4/018705a4-3025-4e3b-884c-ee805b529428/target/test_failures/018705a4-3025-4e3b-884c-ee805b529428_d47f90a974496415048dfbef2bc5134d.html?response-content-type=text%2Fhtml&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=ASIAQPCP3C7LYVRIJ2HP%2F20230322%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20230322T131425Z&X-Amz-Expires=600&X-Amz-Security-Token=IQoJb3JpZ2luX2VjEN3%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLWVhc3QtMSJIMEYCIQDA9S4KjEvUes%2BBf46MNFrR91uVacUL4Fb6hFz2c%2BDUNAIhALC%2FK1HFIS%2FaFsiZeyn99na1OnoHESROe%2FPbjcYK%2F2RmKvoDCKX%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEQABoMMDMyMzc5NzA1MzAzIgyIyDrn3p%2Bf98NXvT4qzgM4eyTaC4EwuV5t7xCmqtUrfCy2lm9ftD3NmJplYEdeuQcOaKtd5Acz4hTEuReaDZYde1eoa9WgR%2BabHy5N3cWO1ndI%2FqfanO5CeUspza7kfaGg4jcDh1e68QAXRy2ciuK2hWWWw0OF8FErTYG3q5dmjOaHaLeUipG%2FdeWF4iIs4BLPVvJA3ZTNGTFPxwc6%2BtD1eJSobey%2Bi45tcTsrCkXm9UtuOSBtW1vYpFL2zkxLoDWV7m%2F%2F5MSNU53L4%2BWGp8bM4aFCo1fXa9IDYv5MQTn7z1CBi2qUn%2FJzAN0LlBwLaAYIDd7TdLN5c3FPzyoTGoknhQQh%2BB6G1qVmZtXwfSYHGYL7rOjv%2FmPHYHpwniyTKitGBHKGAvToHr%2B37wpFpBhpGzZoa8q4e6esRN%2F94wItt%2BoYTh%2FraQTxtqsG8PEZnUJ%2F2H%2FyeNck4rbePnirxVBTt1FAwABpM5TfJEFHd9EYESsSsJ6WIpv43Gc1XbOeiC6MUf502NfAlxhqayhJ1Rux6L9y%2FCI5wbVC9VwI9LrbsavgTt21re6TZgazqt6x9jTZYAqfAZXhIcoUXOreoEBsfqhSTf6RlDY%2FzJ31rDz0dAhXl0QiEZnp%2By%2F6S7cwyeHroAY6pAFByPZ8bWAwDobR8BwKUCZShocd7SssJQqhMyo5E%2FK5aYYPXo3uCijbUcKvsHnyqllCFpA1t5LtyPjoyxSRewnrEueEop%2FAAukBF7%2FrIVZEdwhgWzne5QqK2bV9SMP92RYpDQ8Pff9NrRsgk9qVTKfMdE%2BTKSDt0zBl5gguqn7DLKsJdjBfs4nnXrJlxAKh%2F%2BXpSvKSX2vNh%2F7KZaOEB5R1uuZCFw%3D%3D&X-Amz-SignedHeaders=host&X-Amz-Signature=0a5787d518338968b49ac9bc085ad1b7d019b47be1ad2cb860ecc8b92e11e4a0)) [#152818](#152818) was a first attempt at fixing this, but I forgot to update one of the tests.
rudolf
added
the
Epic:ScaleMigrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses flakiness of:
These tests fail because we have a race condition. We are checking certain conditions in the log files, and sometimes we do it before the logs are actually written.
With the Kibana migrator test kit, we can actually flush + wait for all the logging appenders. This way, we are sure that the logs are complete when we inspect them in the tests.