Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded EUI to v76.0.0 #152506

Merged
merged 25 commits into from
Mar 14, 2023
Merged
Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
7a210af
Upgraded EUI to v76.0.0
JasonStoltz Mar 1, 2023
d2322f2
Updated snapshots
JasonStoltz Mar 2, 2023
a6d2dbf
Patched to 76.0.1
JasonStoltz Mar 2, 2023
66da17e
Merge branch 'main' into eui-v76.0.0
JasonStoltz Mar 6, 2023
8614cf5
Fixed snapshot
JasonStoltz Mar 6, 2023
0dd30b1
Merge branch 'main' into eui-v76.0.0
JasonStoltz Mar 6, 2023
41d1ff5
alert → warning, crossInACircleFilled → error
daveyholler Mar 6, 2023
fdbcb18
Convert more instances of `crossInACircleFilled`
cee-chen Mar 7, 2023
29c3495
Convert instances of `alert` usages combined w/ error vars & danger c…
cee-chen Mar 7, 2023
f937d95
Convert remaining instances of `alert` icon types to `warning`
cee-chen Mar 7, 2023
7308657
Update tests, mocks, and snapshots with `alert`->`warning`
cee-chen Mar 7, 2023
d424b0e
Merge branch 'main' into eui-v76.0.0
cee-chen Mar 7, 2023
4c6c01a
Fix more snapshots
cee-chen Mar 7, 2023
a30d04f
Merge branch 'main' into eui-v76.0.0
kibanamachine Mar 8, 2023
ae2ebad
Merge remote-tracking branch 'upstream/main' into eui-v76.0.0
cee-chen Mar 8, 2023
1351cba
[PR feedback] Fix server-side warning icon
cee-chen Mar 8, 2023
9b2eb8f
[PR feedback] Switch `error` icon to `warning`
cee-chen Mar 8, 2023
3e75f2b
Actually fix SSR warning icon
cee-chen Mar 8, 2023
48ca8eb
Merge branch 'main' into eui-v76.0.0
kibanamachine Mar 8, 2023
ca4887c
Merge branch 'main' into eui-v76.0.0
kibanamachine Mar 9, 2023
15a2b70
Update to latest EUI v76.0.2 backport
cee-chen Mar 9, 2023
7edfcf4
Merge remote-tracking branch 'upstream/main' into eui-v76.0.0
cee-chen Mar 9, 2023
e62fc7c
Merge branch 'main' into eui-v76.0.0
jbudz Mar 10, 2023
fb004ab
Merge branch 'main' into eui-v76.0.0
jbudz Mar 14, 2023
c6e73d4
Merge branch 'main' into eui-v76.0.0
kibanamachine Mar 14, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion examples/files_example/public/components/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export const FilesExampleApp = ({ files, notifications }: FilesExampleAppDeps) =
) : status === 'AWAITING_UPLOAD' ? (
<EuiIcon type="clock" aria-label={status} />
) : (
<EuiIcon color="danger" type="alert" arial-label={status} />
<EuiIcon color="danger" type="warning" arial-label={status} />
),
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const ConfirmButtonIcon: FunctionComponent<Props> = ({
disabled={disabled}
aria-label={confirmationText}
color="warning"
iconType="alert"
iconType="warning"
onClick={onConfirm}
/>
</EuiToolTip>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export const PageSimpleStringStream: FC = () => {
<p>{data}</p>
</EuiText>
{errors.length > 0 && (
<EuiCallOut title="Sorry, there was an error" color="danger" iconType="alert">
<EuiCallOut title="Sorry, there was an error" color="danger" iconType="warning">
{errors.length === 1 ? (
<p>{errors[0]}</p>
) : (
Expand Down
2 changes: 1 addition & 1 deletion examples/routing_example/public/get_message_example.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export function GetMessageRouteExample({ getMessageById }: Props) {
</EuiFormRow>

{error !== undefined ? (
<EuiCallOut color="danger" iconType="alert">
<EuiCallOut color="danger" iconType="warning">
{error.message}
</EuiCallOut>
) : null}
Expand Down
2 changes: 1 addition & 1 deletion examples/routing_example/public/post_message_example.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export function PostMessageRouteExample({ postMessage, addSuccessToast }: Props)
</EuiFormRow>

{error !== undefined ? (
<EuiCallOut color="danger" iconType="alert">
<EuiCallOut color="danger" iconType="warning">
{error.message}
</EuiCallOut>
) : null}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export function RandomNumberBetweenRouteExample({ fetchRandomNumberBetween }: Pr
</EuiFormRow>

{error !== undefined ? (
<EuiCallOut color="danger" iconType="alert">
<EuiCallOut color="danger" iconType="warning">
{error.message}
</EuiCallOut>
) : null}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export function RandomNumberRouteExample({ fetchRandomNumber }: Props) {
</EuiButton>

{error !== undefined ? (
<EuiCallOut color="danger" iconType="alert">
<EuiCallOut color="danger" iconType="warning">
{error}
</EuiCallOut>
) : null}
Expand Down
4 changes: 2 additions & 2 deletions examples/search_examples/public/search/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,7 @@ export const SearchExamplesApp = ({
<EuiButtonEmpty
size="xs"
onClick={() => data.search.session.start()}
iconType="alert"
iconType="warning"
data-test-subj="searchExamplesStartSession"
>
<FormattedMessage
Expand All @@ -795,7 +795,7 @@ export const SearchExamplesApp = ({
<EuiButtonEmpty
size="xs"
onClick={() => data.search.session.clear()}
iconType="alert"
iconType="warning"
data-test-subj="searchExamplesClearSession"
>
<FormattedMessage
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
"@elastic/datemath": "5.0.3",
"@elastic/elasticsearch": "npm:@elastic/[email protected]",
"@elastic/ems-client": "8.4.0",
"@elastic/eui": "75.1.2",
"@elastic/eui": "76.0.2",
"@elastic/filesaver": "1.1.2",
"@elastic/node-crypto": "1.2.1",
"@elastic/numeral": "^2.5.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -724,7 +724,7 @@ function TableListViewComp<T extends UserContentCommonSchema>({
/>
}
color="danger"
iconType="alert"
iconType="warning"
>
<p>
<FormattedMessage
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const AppNotFound = () => (
<EuiPageBody>
<EuiPageContent verticalPosition="center" horizontalPosition="center">
<EuiEmptyPrompt
iconType="alert"
iconType="warning"
iconColor="danger"
title={
<h2>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const ErrorPage: React.FC<Props> = ({ title, children }) => {
<EuiPageBody>
<EuiPageContent verticalPosition="center" horizontalPosition="center">
<EuiEmptyPrompt
iconType="alert"
iconType="warning"
iconColor="danger"
title={<h2>{title}</h2>}
body={children}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export class FatalErrorsScreen extends React.Component<Props, State> {
<EuiPageBody>
<EuiPageContent verticalPosition="center" horizontalPosition="center">
<EuiEmptyPrompt
iconType="alert"
iconType="warning"
iconColor="danger"
title={
<h2>
Expand Down Expand Up @@ -119,7 +119,7 @@ export class FatalErrorsScreen extends React.Component<Props, State> {
]}
/>
{this.state.errors.map((error, i) => (
<EuiCallOut key={i} title={error.message} color="danger" iconType="alert">
<EuiCallOut key={i} title={error.message} color="danger" iconType="warning">
<EuiCodeBlock language="bash" className="eui-textBreakAll">
{`Version: ${this.props.kibanaVersion}` +
'\n' +
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/kbn-react-field/src/field_icon/field_icon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export const typeToEuiIconMap: Partial<Record<string, EuiTokenProps>> = {
binary: { iconType: 'tokenBinary' },
boolean: { iconType: 'tokenBoolean' },
// icon for an index pattern mapping conflict in discover
conflict: { iconType: 'alert', color: 'euiColorVis9', shape: 'square' },
conflict: { iconType: 'warning', color: 'euiColorVis9', shape: 'square' },
date: { iconType: 'tokenDate' },
date_range: { iconType: 'tokenDate' },
dense_vector: { iconType: 'tokenDenseVector' },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ export const useField = ({
<EuiIcon
data-test-subj="mappingConflictsWarningIcon"
tabIndex={0}
type="alert"
type="warning"
title={i18n.FIELD_CONFLICT_INDICES_WARNING_TITLE}
size="s"
css={{ marginLeft: `${sPaddingSize}` }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const EmptyViewerStateComponent: FC<EmptyViewerStateProps> = ({
case ViewerStatus.ERROR: {
return {
color: 'danger' as ExpressionColor,
iconType: 'alert',
iconType: 'error',
title: (
<h2 data-test-subj="errorTitle">{title || i18n.EMPTY_VIEWER_STATE_ERROR_TITLE}</h2>
),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const ErrorContent: FunctionComponent<Props> = ({ error }) => {
return (
<EuiEmptyPrompt
data-test-subj="errorPrompt"
iconType="alert"
iconType="warning"
iconColor="danger"
titleSize="xs"
title={<h3>{i18nTexts.loadingFilesErrorTitle}</h3>}
Expand Down
2 changes: 1 addition & 1 deletion src/dev/license_checker/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,6 @@ export const LICENSE_OVERRIDES = {
'[email protected]': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts
'@mapbox/[email protected]': ['MIT'], // license in readme https://github.com/tmcw/jsonlint
'@elastic/[email protected]': ['Elastic License 2.0'],
'@elastic/eui@75.1.2': ['SSPL-1.0 OR Elastic License 2.0'],
'@elastic/eui@76.0.2': ['SSPL-1.0 OR Elastic License 2.0'],
'[email protected]': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry
};
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export class AdvancedSettings extends Component<AdvancedSettingsProps> {
return (
<div>
<EuiSpacer size="xl" />
<EuiCallOut title={this.props.callOutTitle} iconType="alert">
<EuiCallOut title={this.props.callOutTitle} iconType="warning">
<p>{this.props.callOutSubtitle}</p>
</EuiCallOut>
<EuiSpacer size="xl" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ export class Field extends PureComponent<FieldProps> {
{unsavedChanges ? (
<EuiIconTip
anchorClassName="mgtAdvancedSettings__fieldTitleUnsavedIcon"
type={isInvalid ? 'alert' : 'dot'}
type={isInvalid ? 'warning' : 'dot'}
color={isInvalid ? 'danger' : 'warning'}
aria-label={unsavedIconLabel}
content={unsavedIconLabel}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const VisualizationNoResults: FC<Props> = ({
return (
<EmptyPlaceholder
dataTestSubj="partitionVisNegativeValues"
icon="alert"
icon="warning"
iconColor="warning"
message={message}
renderComplete={renderComplete}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ export const TagCloudChart = ({
{warning && (
<div className="tgcChart__warning">
<EuiIconTip
type="alert"
type="warning"
color="warning"
content={
<FormattedMessage
Expand All @@ -232,7 +232,7 @@ export const TagCloudChart = ({
{tagCloudData.length > MAX_TAG_COUNT && (
<div className="tgcChart__warning">
<EuiIconTip
type="alert"
type="warning"
color="warning"
content={
<FormattedMessage
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/charts/public/static/components/warnings.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export function Warnings({
}
`}
iconSize="s"
iconType="alert"
iconType="warning"
minWidth={0}
onClick={onWarningButtonClick}
size="s"
Expand All @@ -69,7 +69,7 @@ export function Warnings({
) : (
<EuiButtonEmpty
color="warning"
iconType="alert"
iconType="warning"
onClick={onWarningButtonClick}
size="xs"
data-test-subj={dataTestSubj}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const SomethingWentWrongCallout: FunctionComponent<Props> = ({ error, onB

return (
<EuiCallOut
iconType="alert"
iconType="warning"
color="danger"
title={i18n.translate('console.loadingError.title', {
defaultMessage: 'Cannot load Console',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const ControlFrameError = ({ error }: ControlFrameErrorProps) => {
<EuiButtonEmpty
color="danger"
iconSize="m"
iconType={'alert'}
iconType="error"
onClick={() => setPopoverOpen((open) => !open)}
className={'errorEmbeddableCompact__button'}
textProps={{ className: 'errorEmbeddableCompact__text' }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export const OptionsListPopoverTitle = () => {
<EuiFlexItem data-test-subj="optionsList-allow-expensive-queries-warning" grow={false}>
<EuiIconTip
aria-label="Warning"
type="alert"
type="warning"
color="warning"
content={OptionsListStrings.popover.getAllowExpensiveQueriesWarning()}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ const searchSessionIndicatorViewStateToProps: {
[SearchSessionState.Canceled]: {
button: {
color: 'danger',
iconType: 'alert',
iconType: 'error',
'aria-label': i18n.translate('data.searchSessionIndicator.canceledIconAriaLabel', {
defaultMessage: 'Search session stopped',
}),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export const createDeleteActionDescriptor = (
uiSession: UISession,
core: CoreStart
): IClickActionDescriptor => ({
iconType: 'crossInACircleFilled',
iconType: 'trash',
label: <FormattedMessage id="data.mgmt.searchSessions.actionDelete" defaultMessage="Delete" />,
onClick: async () => {
const ref = core.overlays.openModal(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ const getStatusAttributes = ({

case SearchSessionStatus.CANCELLED:
return {
icon: <EuiIcon color="#9AA" type="crossInACircleFilled" />,
icon: <EuiIcon color="#9AA" type="error" />,
label: <TableText>{getStatusText(session.status)}</TableText>,
toolTipContent: i18n.translate('data.mgmt.searchSessions.status.message.cancelled', {
defaultMessage: 'Cancelled by user',
Expand All @@ -114,7 +114,7 @@ const getStatusAttributes = ({
case SearchSessionStatus.ERROR:
return {
textColor: 'danger',
icon: <EuiIcon color="danger" type="crossInACircleFilled" />,
icon: <EuiIcon color="danger" type="error" />,
label: <TableText>{getStatusText(session.status)}</TableText>,
toolTipContent:
session.errors && session.errors.length > 0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export const getColumns = (
<>
{' '}
<EuiIconTip
type="alert"
type="warning"
content={
<FormattedMessage
id="data.mgmt.searchSessions.table.notRestorableWarning"
Expand All @@ -127,7 +127,7 @@ export const getColumns = (
<>
{' '}
<EuiIconTip
type="alert"
type="warning"
iconProps={{ 'data-test-subj': 'versionIncompatibleWarningTestSubj' }}
content={
<FormattedMessage
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export function ShardFailureModal({ request, response, title, onClose }: Props)
) {
// this should never ever happen, but just in case
return (
<EuiCallOut title="Sorry, there was an error" color="danger" iconType="alert">
<EuiCallOut title="Sorry, there was an error" color="danger" iconType="warning">
The ShardFailureModal component received invalid properties
</EuiCallOut>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,12 @@ export function DeleteFieldModal({ fieldsToDelete, closeModal, confirmDelete }:
confirmButtonText={confirmButtonText}
confirmButtonDisabled={confirmContent?.toUpperCase() !== 'REMOVE'}
>
<EuiCallOut color="warning" title={i18nTexts.warningRemovingFields} iconType="alert" size="s">
<EuiCallOut
color="warning"
title={i18nTexts.warningRemovingFields}
iconType="warning"
size="s"
>
{isMultiple && (
<>
<p>{warningMultipleFields}</p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export const SaveFieldTypeOrNameChangedModal: React.FC<Props> = ({
<EuiCallOut
color="warning"
title={i18nTexts.warningChangingFields}
iconType="alert"
iconType="warning"
size="s"
/>
<EuiSpacer />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ const FieldEditorComponent = ({ field, onChange, onFormModifiedChange }: Props)
<EuiCallOut
color="warning"
title={changeWarning}
iconType="alert"
iconType="warning"
size="s"
data-test-subj="changeWarning"
/>
Expand Down
Loading