[Discover] Optimize popover size for grid cell expansion #152480
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
| * in compliance with, at your election, the Elastic License 2.0 or the Server | ||
| * Side Public License, v 1. | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import { mount } from 'enzyme'; | ||
| import { getRenderCellPopoverFn } from './get_render_cell_popover'; | ||
| import { EuiDataGridCellPopoverElementProps } from '@elastic/eui'; | ||
|
|
||
| describe('Discover grid cell popover rendering', function () { | ||
| const DiscoverGridCellPopover = getRenderCellPopoverFn() as React.FC< | ||
| Pick<EuiDataGridCellPopoverElementProps, 'cellActions' | 'setCellPopoverProps'> | ||
| >; | ||
| const CellValue = ({ schema }: { schema: string }) => { | ||
| return <div>{schema}</div>; | ||
| }; | ||
|
|
||
| it('renders correctly', () => { | ||
| const setMock = jest.fn(); | ||
| const component = mount( | ||
| <DiscoverGridCellPopover | ||
| cellActions={<button>{'test'}</button>} | ||
| setCellPopoverProps={setMock} | ||
| > | ||
| <CellValue schema="string" /> | ||
| </DiscoverGridCellPopover> | ||
| ); | ||
| expect(component.html()).toMatchInlineSnapshot( | ||
| `"<div class=\\"euiFlexGroup css-4b375e\\"><div class=\\"euiFlexItem css-9sbomz-euiFlexItem-grow-1\\"><div>string</div></div><div class=\\"euiFlexItem css-kpsrin-euiFlexItem-growZero\\"><button>test</button></div></div>"` | ||
| ); | ||
| expect(setMock).toHaveBeenCalledWith({ | ||
| panelClassName: 'dscDiscoverGrid__cellPopover', | ||
| }); | ||
| }); | ||
|
|
||
| it('renders correctly for json view', () => { | ||
| const setMock = jest.fn(); | ||
| const component = mount( | ||
| <DiscoverGridCellPopover | ||
| cellActions={<button>{'test'}</button>} | ||
| setCellPopoverProps={setMock} | ||
| > | ||
| <CellValue schema="kibana-json" /> | ||
| </DiscoverGridCellPopover> | ||
| ); | ||
| expect(component.html()).toMatchInlineSnapshot( | ||
| `"<div class=\\"euiFlexGroup css-4b375e\\"><div class=\\"euiFlexItem css-9sbomz-euiFlexItem-grow-1\\"><div>kibana-json</div></div><div class=\\"euiFlexItem css-kpsrin-euiFlexItem-growZero\\"><button>test</button></div></div>"` | ||
| ); | ||
| expect(setMock).toHaveBeenCalledWith({ | ||
| panelClassName: 'dscDiscoverGrid__cellPopover dscDiscoverGrid__cellPopover--withJson', | ||
| }); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
| * in compliance with, at your election, the Elastic License 2.0 or the Server | ||
| * Side Public License, v 1. | ||
| */ | ||
|
|
||
| import React, { useEffect } from 'react'; | ||
| import { css } from '@emotion/react'; | ||
| import classnames from 'classnames'; | ||
| import { EuiDataGridProps, EuiFlexGroup, EuiFlexItem } from '@elastic/eui'; | ||
|
|
||
| const containerStyles = css` | ||
| height: 100%; | ||
| `; | ||
|
|
||
| export const getRenderCellPopoverFn = | ||
| (): EuiDataGridProps['renderCellPopover'] => | ||
| ({ cellActions, setCellPopoverProps, children }) => { | ||
| useEffect(() => { | ||
| setCellPopoverProps({ | ||
| panelClassName: classnames('dscDiscoverGrid__cellPopover', { | ||
| 'dscDiscoverGrid__cellPopover--withJson': | ||
| children && | ||
| typeof children === 'object' && | ||
| 'props' in children && | ||
| children.props?.schema === 'kibana-json', | ||
| }), | ||
| }); | ||
| }, [setCellPopoverProps, children]); | ||
|
|
||
| return ( | ||
| <EuiFlexGroup responsive={false} direction="column" gutterSize="none" css={containerStyles}> | ||
| <EuiFlexItem grow={true}>{children}</EuiFlexItem> | ||
| <EuiFlexItem grow={false}>{cellActions}</EuiFlexItem> | ||
| </EuiFlexGroup> | ||
| ); | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely think, even if we decide not to allow resizing, having the JSON view in a larger dimension makes much sense