Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Engines Search Preview - "Sort By" #152253

Merged

Conversation

sloanelybutsurely
Copy link

@sloanelybutsurely sloanelybutsurely commented Feb 27, 2023

Summary

Screen.Recording.2023-03-02.at.4.37.09.PM.mov

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@sloanelybutsurely sloanelybutsurely changed the title [Enterprise Search] Add "Sort By" select to search preview [Enterprise Search] Engines Search Preview - "Sort By" Feb 27, 2023
@sloanelybutsurely sloanelybutsurely force-pushed the 4033-search-preview-sorting branch 3 times, most recently from 6cf951e to 3a35ba4 Compare March 2, 2023 21:36
@sloanelybutsurely sloanelybutsurely marked this pull request as ready for review March 2, 2023 21:38
@sloanelybutsurely sloanelybutsurely requested a review from a team March 2, 2023 21:38
@sloanelybutsurely sloanelybutsurely added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch labels Mar 2, 2023
@sloanelybutsurely sloanelybutsurely force-pushed the 4033-search-preview-sorting branch from 3a35ba4 to 1bf589b Compare March 6, 2023 13:27
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.2MB 2.2MB +2.1KB
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 428 430 +2

Total ESLint disabled count

id before after diff
securitySolution 506 508 +2

History

  • 💚 Build #111835 succeeded 3a35ba4fce8374365905f527ee9310496daa9c6e
  • 💔 Build #111502 failed 6cf951ede614a368b073137cb454d230c52f6086
  • 💔 Build #110858 failed 8744945ee0eb237084689f5a675a2a8567f5cacb
  • 💔 Build #110791 failed a1df3287b18ae4e6053d71ae8c4dc6e45989d44d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sloanelybutsurely sloanelybutsurely requested a review from a team March 6, 2023 15:57
@sloanelybutsurely sloanelybutsurely merged commit e94c1a6 into elastic:main Mar 6, 2023
@sloanelybutsurely sloanelybutsurely deleted the 4033-search-preview-sorting branch March 6, 2023 18:05
@kibanamachine kibanamachine added v8.8.0 backport:skip This commit does not require backporting labels Mar 6, 2023
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
## Summary


https://user-images.githubusercontent.com/1699281/222561456-55666a32-0508-4c49-b721-4bd71afb0d72.mov

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants