Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics/Uptime] Separate e2e tests by app #152197

Merged
merged 10 commits into from
Jun 7, 2023
Merged

[Synthetics/Uptime] Separate e2e tests by app #152197

merged 10 commits into from
Jun 7, 2023

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Feb 27, 2023 •
edited
Loading

Summary

Separate e2e tests structure by app !!

New structure

image

@shahzad31 shahzad31 added the ci:reuse-kibana-build Experimental label Mar 2, 2023
@shahzad31 shahzad31 force-pushed the separete-tests branch 2 times, most recently from 3956756 to 9c1aa72 Compare June 7, 2023 09:11
@shahzad31 shahzad31 changed the title test [Synthetics/Uptime] Separate e2e tests by app Jun 7, 2023
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.9.0 labels Jun 7, 2023
@shahzad31 shahzad31 marked this pull request as ready for review June 7, 2023 11:58
@shahzad31 shahzad31 requested review from a team as code owners June 7, 2023 11:58
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jun 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
exploratoryView 216.9KB 217.0KB +38.0B
Unknown metric groups

ESLint disabled in files

id before after diff
synthetics 7 8 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 413 417 +4
synthetics 101 99 -2
total +4

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 497 501 +4
synthetics 108 107 -1
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dominiqueclarke
dominiqueclarke approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbudz
jbudz reviewed Jun 7, 2023
View reviewed changes
.buildkite/scripts/steps/functional/uptime_plugin.sh

cd "$XPACK_DIR"

node plugins/synthetics/scripts/uptime_e2e.js --kibana-install-dir "$KIBANA_BUILD_LOCATION" ${GREP:+--grep \"${GREP}\"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the grep portion used for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's primarily used to filter out tests by journey name

@shahzad31 shahzad31 merged commit 0ea97e2 into elastic:main Jun 7, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 7, 2023
@shahzad31 shahzad31 deleted the separete-tests branch June 7, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:reuse-kibana-build Experimental release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shahzad31 @elasticmachine @kibana-ci @jbudz @dominiqueclarke @kibanamachine