Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a11y improvements #152126

Merged
merged 6 commits into from
Mar 8, 2023
Merged

Implement a11y improvements #152126

merged 6 commits into from
Mar 8, 2023

Conversation

claracruz
Copy link
Contributor

@claracruz claracruz commented Feb 24, 2023 •
edited
Loading

Fixes: #143878

This PR updates the guided onboarding panel to utilise a custom flyout created based on the example accessible custom flyout

@claracruz claracruz added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Journey/Onboarding Platform Journey Onboarding team v8.8.0 labels Feb 24, 2023
@claracruz claracruz force-pushed the guided_onboarding/8.8/a11y_improvements branch from 7bef3d2 to 0587b42 Compare February 27, 2023 11:41
@claracruz claracruz marked this pull request as ready for review February 27, 2023 14:25
@claracruz claracruz requested a review from a team as a code owner February 27, 2023 14:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

@claracruz
Copy link
Contributor Author

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor

@yuliacech can you help review this?

yuliacech
yuliacech reviewed Mar 1, 2023
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this, @claracruz!
I tested locally and noticed that the flyout background is not updated in the dark theme (screenshot below). Could you please have a look?
Screenshot 2023-03-01 at 10 21 25

@yuliacech
Copy link
Contributor

I also noticed that the flyout height got smaller, is this an intended change?

before
Screenshot 2023-03-01 at 10 24 22

after
Screenshot 2023-03-01 at 10 24 08

@claracruz claracruz force-pushed the guided_onboarding/8.8/a11y_improvements branch 2 times, most recently from fb6123c to 5be0d62 Compare March 7, 2023 11:26
yuliacech
yuliacech reviewed Mar 7, 2023
View reviewed changes
src/plugins/guided_onboarding/public/components/guide_panel_flyout/index.tsx Outdated
toggleGuide: () => void;
isGuideReadyToComplete: boolean;
guideConfig?: GuideConfig;
styles: any;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think instead of any we could use something like ReturnType<typeof getGuidePanelStyles>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, missed this. It was a placeholder

yuliacech
yuliacech approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for addressing my feedback, @claracruz!
Latest changes LGTM, re-tested locally 👍

@claracruz claracruz force-pushed the guided_onboarding/8.8/a11y_improvements branch from 5be0d62 to c4ab3a0 Compare March 8, 2023 11:00
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
guidedOnboarding 23 28 +5

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
guidedOnboarding 23.7KB 26.9KB +3.2KB
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 428 430 +2

Total ESLint disabled count

id before after diff
securitySolution 505 507 +2

History

  • 💚 Build #112344 succeeded 5be0d627c1d7e232ae621a8606a32ff92df6e9c1
  • 💚 Build #110665 succeeded 914fe90fbc034dce6f532f58598a4e4d3277b998
  • 💔 Build #110641 failed 3e5c0d9a66e88c9e80941076a4189dc66c0e7cc8
  • 💔 Build #110596 failed 0587b4218a3993cebd9b6dcb22015fb309117751
  • 💔 Build #110381 failed 7bef3d223e69a33e18893ec302f906674040e041

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@claracruz claracruz merged commit b686e0f into elastic:main Mar 8, 2023
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
@claracruz @bmorelli25
Implement a11y improvements (elastic#152126)
cb64855 
Fixes: elastic#143878

This PR updates the guided onboarding panel to utilise a custom flyout
created based on the [example accessible custom
flyout](https://eui.elastic.co/pr_6247/#/utilities/portal#a-custom-flyout)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuliacech yuliacech yuliacech approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Journey/Onboarding Platform Journey Onboarding team v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Guided onboarding] A11y improvements
5 participants
@claracruz @elasticmachine @alisonelizabeth @yuliacech @kibana-ci