[Synthetics] Error timeline date range #151965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
release_note:skip
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
force-pushed
the
fix-error-timeline
branch
from
e32d784 to
3d9d38b
Compare
| } else { | ||
| itemIdToExpandedRowMapValues[item._id] = <></>; | ||
| } | ||
| const toggleDetails = useCallback( |
There was a problem hiding this comment.
Is this related to errors? is here something I should regression test here?
There was a problem hiding this comment.
it just wraps toggleDetails in callBack. Should be fine.
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 1, 2023
(cherry picked from commit d051183)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 1, 2023
# Backport This will backport the following commits from `main` to `8.7`: - [[Synthetics] Error timeline date range (#151965)](#151965) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-01T15:46:25Z","message":"[Synthetics] Error timeline date range (#151965)","sha":"d051183adee6328ef86a8124b835ae69bfbae802","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:uptime","release_note:skip","v8.7.0","v8.8.0"],"number":151965,"url":"https://github.com/elastic/kibana/pull/151965","mergeCommit":{"message":"[Synthetics] Error timeline date range (#151965)","sha":"d051183adee6328ef86a8124b835ae69bfbae802"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151965","number":151965,"mergeCommit":{"message":"[Synthetics] Error timeline date range (#151965)","sha":"d051183adee6328ef86a8124b835ae69bfbae802"}}]}] BACKPORT--> Co-authored-by: Shahzad <[email protected]>
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #151774
Fixes #151789 Fixes errors breadcrumb link as well
Use full range of error state start and end as guide for visualising error timeline