Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tasks instead of marking them as failed #151870

Closed

Conversation

mikecote
Copy link
Contributor

Part 1 of #79977.

In this PR, I'm making Task Manager remove tasks instead of updating them with status: failed whenever a task gets marked as failed and never runs again.

@mikecote mikecote added release_note:skip Skip the PR/issue when compiling release notes Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0 labels Feb 22, 2023
@mikecote mikecote self-assigned this Feb 22, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Feb 22, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #49 / alerting api integration security and spaces enabled - Group 3 Alerts - Group 3 alerts bulkDelete space_1_all_alerts_none_actions at space1 should handle bulk delete of one rule appropriately based on id
  • [job] [logs] FTR Configs #49 / alerting api integration security and spaces enabled - Group 3 Alerts - Group 3 alerts bulkDelete space_1_all_alerts_none_actions at space1 should handle bulk delete of one rule appropriately based on id
  • [job] [logs] FTR Configs #49 / alerting api integration security and spaces enabled - Group 3 Alerts - Group 3 alerts bulkDelete space_1_all_alerts_none_actions at space1 should handle bulk delete of several rules ids appropriately based on ids
  • [job] [logs] FTR Configs #49 / alerting api integration security and spaces enabled - Group 3 Alerts - Group 3 alerts bulkDelete space_1_all_alerts_none_actions at space1 should handle delete alert request appropriately when consumer is "alerts"
  • [job] [logs] FTR Configs #49 / alerting api integration security and spaces enabled - Group 3 Alerts - Group 3 alerts bulkDelete space_1_all_alerts_none_actions at space1 should handle delete alert request appropriately when consumer is "alerts"
  • [job] [logs] FTR Configs #49 / alerting api integration security and spaces enabled - Group 3 Alerts - Group 3 alerts bulkDelete space_1_all_with_restricted_fixture at space1 should handle bulk delete of one rule appropriately based on id
  • [job] [logs] FTR Configs #49 / alerting api integration security and spaces enabled - Group 3 Alerts - Group 3 alerts bulkDelete space_1_all_with_restricted_fixture at space1 should handle bulk delete of one rule appropriately based on id when consumer is the same as producer
  • [job] [logs] FTR Configs #49 / alerting api integration security and spaces enabled - Group 3 Alerts - Group 3 alerts bulkDelete space_1_all_with_restricted_fixture at space1 should handle bulk delete of several rules ids appropriately based on filter
  • [job] [logs] FTR Configs #49 / alerting api integration security and spaces enabled - Group 3 Alerts - Group 3 alerts bulkDelete space_1_all_with_restricted_fixture at space1 should handle bulk delete of several rules ids appropriately based on filter
  • [job] [logs] FTR Configs #49 / alerting api integration security and spaces enabled - Group 3 Alerts - Group 3 alerts bulkDelete space_1_all_with_restricted_fixture at space1 should handle bulk delete of several rules ids appropriately based on ids
  • [job] [logs] FTR Configs #49 / alerting api integration security and spaces enabled - Group 3 Alerts - Group 3 alerts bulkDelete space_1_all_with_restricted_fixture at space1 should handle delete alert request appropriately when consumer is "alerts"
  • [job] [logs] FTR Configs #49 / alerting api integration security and spaces enabled - Group 3 Alerts - Group 3 alerts bulkDelete superuser at space1 should handle bulk delete of one rule appropriately based on id
  • [job] [logs] FTR Configs #49 / alerting api integration security and spaces enabled - Group 3 Alerts - Group 3 alerts bulkDelete superuser at space1 should handle bulk delete of several rules ids appropriately based on ids
  • [job] [logs] FTR Configs #15 / task_manager scheduling and running tasks should allow a failed task to be rerun using runSoon
  • [job] [logs] FTR Configs #15 / task_manager scheduling and running tasks should allow a failed task to be rerun using runSoon

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mikecote

@mikecote mikecote closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Task Manager release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants