[8.7] Add date_nanos support to Time field (#151374) #151724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: elastic#145855 `Time field` in rule update/create forms shows only the fields with `date` data type. This PR adds `date_nanos` type as well. ## To verify: - Create an index that has fields with `date` and `date_nanos` types. ``` PUT test-index-date { "mappings": { "properties": { "date": { "type": "date" }, "timestamp": { "type": "date_nanos" } } } } ``` - Add data with `date` and `date_nanos` data types Note: You can use https://www.site24x7.com/tools/time-stamp-converter.html address to generate date_nanos timestamps with a date you desired. ``` PUT test-index-date/_bulk?refresh { "index" : { "_id" : "1" } } { "date": "2023-02-15T18:00:00.000Z", "timestamp": 1676480400000} { "index" : { "_id" : "2" } } { "date": "2023-02-15T18:00:00.000Z", "timestamp": 1676480400000 } ``` - Open a Rule create form and select `Elasticsearch query` - Select `Query DSL` - Click on `select an index` - Type the above index name (test-index-date) in `Indices to query` input - Select `timestamp` from time field - Click on `Test Query` button and expect to see `Query matched 2 documents in the last 5m.` (cherry picked from commit 58204cf)
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: cc @ersin-erdal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.7:Questions ?
Please refer to the Backport tool documentation