Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualizations] Fixes legend actions accessibility #151678

Merged
merged 4 commits into from
Feb 22, 2023

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Feb 21, 2023

Summary

Closes #148647

Fixes accessibility problem on legend actions button.

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This commit does not require backporting v8.8.0 labels Feb 21, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionPartitionVis 52.5KB 52.6KB +115.0B
expressionXY 120.0KB 120.1KB +105.0B
total +220.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Feb 21, 2023
@stratoula stratoula marked this pull request as ready for review February 21, 2023 15:13
@stratoula stratoula requested a review from a team as a code owner February 21, 2023 15:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only 👍

@stratoula stratoula merged commit 67e19ec into elastic:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensures every ARIA button, link and menuitem has an accessible name validation error in demo flights chart
5 participants