-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EUI: Reset CSS #15134
Closed
Closed
EUI: Reset CSS #15134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
added
Team:Platform-Design
Team Label for Kibana Design Team. Support the Analyze group of plugins.
v7.0.0
labels
Nov 23, 2017
cjcenizal
force-pushed
the
eui/reset-css
branch
from
November 23, 2017 01:51
e477301
to
f2d598c
Compare
Remove EUI dependency.
cjcenizal
force-pushed
the
eui/reset-css
branch
from
November 23, 2017 05:13
f2d598c
to
134ffac
Compare
Closing in favor of a branch on the original repo: https://github.com/elastic/kibana/tree/eui/reset-css And this issue: #15315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Team:Platform-Design
Team Label for Kibana Design Team. Support the Analyze group of plugins.
v7.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've extracted the commits from #14948 which load the EUI CSS (thereby using its reset), and removing the Bootstrap, UI Framework, and custom reset CSS. Depends upon elastic/eui#153.
We'll need to complete the partial audit below and fix the regressions we find.
Partial audit
Here are a few of the visual regressions incurred by the CSS reset changes.
Notifications
Timepicker
a
elements with nohref
attribute.Query bar
Discover
In "Single document" view, the tabs lack pointer cursors when hovered, possibly because they're
a
elements withouthref
attributes.Note: this applies to the tabs in an expanded row of the doc table, too.
Visualize
sr-only
accessibility class has been deleted, which means all elements previously hidden by it are now visible. We can fix this by replacing this class witheuiScreenReaderOnly
instead.a
elements withouthref
attributes.