[Fleet] Add beta badge to host name format agent policy setting #150855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hop-dev
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
…-ref HEAD~1..HEAD --fix'
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @hop-dev |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 10, 2023
…tic#150855) Add a beta badge to the host name format agent policy setting. As asked here elastic#149059 (comment) I have changed ther deprecated badge to be rounded too as it looked really odd having two different types of badge next to each other. I have used accent color on the beta badge too to differentiate it from the deprecated badge. ### Before <img width="850" alt="Screenshot 2023-02-10 at 11 05 36" src="https://user-images.githubusercontent.com/3315046/218077728-f5ea600b-d0ae-4284-bc90-4e323646f44d.png"> ### After <img width="942" alt="Screenshot 2023-02-10 at 11 05 13" src="https://user-images.githubusercontent.com/3315046/218077762-f90b7a76-b5f7-483f-8118-751c345bbc67.png"> --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit a237aa4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 10, 2023
…#150855) (#150876) # Backport This will backport the following commits from `main` to `8.7`: - [[Fleet] Add beta badge to host name format agent policy setting (#150855)](#150855) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mark Hopkin","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-10T13:18:22Z","message":"[Fleet] Add beta badge to host name format agent policy setting (#150855)\n\nAdd a beta badge to the host name format agent policy setting. As asked\r\nhere\r\nhttps://github.com//issues/149059#issuecomment-1424490013\r\n\r\nI have changed ther deprecated badge to be rounded too as it looked\r\nreally odd having two different types of badge next to each other. I\r\nhave used accent color on the beta badge too to differentiate it from\r\nthe deprecated badge.\r\n\r\n### Before\r\n<img width=\"850\" alt=\"Screenshot 2023-02-10 at 11 05 36\"\r\nsrc=\"https://user-images.githubusercontent.com/3315046/218077728-f5ea600b-d0ae-4284-bc90-4e323646f44d.png\">\r\n\r\n\r\n### After\r\n<img width=\"942\" alt=\"Screenshot 2023-02-10 at 11 05 13\"\r\nsrc=\"https://user-images.githubusercontent.com/3315046/218077762-f90b7a76-b5f7-483f-8118-751c345bbc67.png\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a237aa49623071f5c76b5181de9f1c11cccbc291","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.7.0","v8.8.0"],"number":150855,"url":"https://github.com/elastic/kibana/pull/150855","mergeCommit":{"message":"[Fleet] Add beta badge to host name format agent policy setting (#150855)\n\nAdd a beta badge to the host name format agent policy setting. As asked\r\nhere\r\nhttps://github.com//issues/149059#issuecomment-1424490013\r\n\r\nI have changed ther deprecated badge to be rounded too as it looked\r\nreally odd having two different types of badge next to each other. I\r\nhave used accent color on the beta badge too to differentiate it from\r\nthe deprecated badge.\r\n\r\n### Before\r\n<img width=\"850\" alt=\"Screenshot 2023-02-10 at 11 05 36\"\r\nsrc=\"https://user-images.githubusercontent.com/3315046/218077728-f5ea600b-d0ae-4284-bc90-4e323646f44d.png\">\r\n\r\n\r\n### After\r\n<img width=\"942\" alt=\"Screenshot 2023-02-10 at 11 05 13\"\r\nsrc=\"https://user-images.githubusercontent.com/3315046/218077762-f90b7a76-b5f7-483f-8118-751c345bbc67.png\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a237aa49623071f5c76b5181de9f1c11cccbc291"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150855","number":150855,"mergeCommit":{"message":"[Fleet] Add beta badge to host name format agent policy setting (#150855)\n\nAdd a beta badge to the host name format agent policy setting. As asked\r\nhere\r\nhttps://github.com//issues/149059#issuecomment-1424490013\r\n\r\nI have changed ther deprecated badge to be rounded too as it looked\r\nreally odd having two different types of badge next to each other. I\r\nhave used accent color on the beta badge too to differentiate it from\r\nthe deprecated badge.\r\n\r\n### Before\r\n<img width=\"850\" alt=\"Screenshot 2023-02-10 at 11 05 36\"\r\nsrc=\"https://user-images.githubusercontent.com/3315046/218077728-f5ea600b-d0ae-4284-bc90-4e323646f44d.png\">\r\n\r\n\r\n### After\r\n<img width=\"942\" alt=\"Screenshot 2023-02-10 at 11 05 13\"\r\nsrc=\"https://user-images.githubusercontent.com/3315046/218077762-f90b7a76-b5f7-483f-8118-751c345bbc67.png\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a237aa49623071f5c76b5181de9f1c11cccbc291"}}]}] BACKPORT--> Co-authored-by: Mark Hopkin <[email protected]>
![https://user-images.githubusercontent.com/3315046/218077728-f5ea600b-d0ae-4284-bc90-4e323646f44d.png\">\r\n\r\n\r\n###](https://user-images.githubusercontent.com/3315046/218077728-f5ea600b-d0ae-4284-bc90-4e323646f44d.png\">\r\n\r\n\r\n###){kind=link}
![https://user-images.githubusercontent.com/3315046/218077762-f90b7a76-b5f7-483f-8118-751c345bbc67.png\">\r\n\r\n---------\r\n\r\nCo-authored-by](https://user-images.githubusercontent.com/3315046/218077762-f90b7a76-b5f7-483f-8118-751c345bbc67.png\">\r\n\r\n---------\r\n\r\nCo-authored-by){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a beta badge to the host name format agent policy setting. As asked here #149059 (comment)
I have changed ther deprecated badge to be rounded too as it looked really odd having two different types of badge next to each other. I have used accent color on the beta badge too to differentiate it from the deprecated badge.
Before
After