Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Saved Objects] Remove deprecation notices from server SO types #150839

Merged
merged 4 commits into from
Feb 15, 2023
Merged

[Saved Objects] Remove deprecation notices from server SO types #150839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77a8af1
remove some deprecation notices leaking through server types
jloleysens Feb 10, 2023
9fa6a7b
Merge branch 'main' into fix-so-deprecation-types-server-side
jloleysens Feb 10, 2023
0579b99
move Saved Objects and related types to server-api package and update…
jloleysens Feb 13, 2023
897e83f
Merge branch 'main' into fix-so-deprecation-types-server-side
jloleysens Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/core/saved-objects/core-saved-objects-api-server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,11 @@ export type {
SavedObjectsBulkDeleteStatus,
SavedObjectsBulkDeleteResponse,
} from './src/apis';

export type {
SavedObject,
SavedObjectAttribute,
SavedObjectAttributes,
SavedObjectAttributeSingle,
SavedObjectReference,
} from '@kbn/core-saved-objects-common/src/server_types';
2 changes: 1 addition & 1 deletion packages/core/saved-objects/core-saved-objects-api-server/src/apis/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* Side Public License, v 1.
*/

import type { SavedObject } from '@kbn/core-saved-objects-common';
import type { SavedObject } from '../..';

/**
* Base options used by most of the savedObject APIs.
Expand Down
6 changes: 2 additions & 4 deletions packages/core/saved-objects/core-saved-objects-api-server/src/apis/bulk_create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@
* Side Public License, v 1.
*/

import type {
SavedObjectReference,
SavedObjectsMigrationVersion,
} from '@kbn/core-saved-objects-common';
import type { SavedObjectsMigrationVersion } from '@kbn/core-saved-objects-common';
import type { SavedObjectReference } from '../..';

/**
* Object parameters for the bulk create operation
Expand Down
2 changes: 1 addition & 1 deletion packages/core/saved-objects/core-saved-objects-api-server/src/apis/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

import type { SavedObjectsMigrationVersion } from '@kbn/core-saved-objects-common';
import type { SavedObjectReference } from '@kbn/core-saved-objects-common';
import type { SavedObjectReference } from '../..';
import type { MutatingOperationRefreshSetting, SavedObjectsBaseOptions } from './base';

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/core/saved-objects/core-saved-objects-api-server/src/apis/find.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import type {
AggregationsAggregationContainer,
SortResults,
} from '@elastic/elasticsearch/lib/api/typesWithBodyKey';
import type { SavedObject } from '@kbn/core-saved-objects-common';
import type { SavedObject } from '../..';

type KueryNode = any;

Expand Down
2 changes: 1 addition & 1 deletion packages/core/saved-objects/core-saved-objects-api-server/src/apis/resolve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* Side Public License, v 1.
*/

import type { SavedObject } from '@kbn/core-saved-objects-common';
import type { SavedObject } from '../..';

/**
*
Expand Down
2 changes: 1 addition & 1 deletion packages/core/saved-objects/core-saved-objects-api-server/src/apis/update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* Side Public License, v 1.
*/

import type { SavedObjectReference, SavedObject } from '@kbn/core-saved-objects-common';
import type { SavedObject, SavedObjectReference } from '../..';
import type { MutatingOperationRefreshSetting, SavedObjectsBaseOptions } from './base';

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/core/saved-objects/core-saved-objects-api-server/src/saved_objects_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* Side Public License, v 1.
*/

import type { SavedObject } from '@kbn/core-saved-objects-common';
import type { SavedObject } from '..';
import type {
SavedObjectsBaseOptions,
SavedObjectsFindOptions,
Expand Down
3 changes: 2 additions & 1 deletion packages/core/saved-objects/core-saved-objects-server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,11 @@ export type {
SavedObjectModelTransformationResult,
} from './src/model_version';

// We re-export the SavedObject types here for convenience.
export type {
SavedObject,
SavedObjectAttribute,
SavedObjectAttributes,
SavedObjectAttributeSingle,
SavedObjectReference,
} from '@kbn/core-saved-objects-common/src/server_types';
} from '@kbn/core-saved-objects-api-server';