Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Response Ops][Alerting] Adding ability for rule types to specify custom formatting for getSummarizedAlerts function #150829

Merged
merged 3 commits into from
Feb 13, 2023

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Feb 10, 2023

Resolves #150776

Summary

As part of the POC to onboard detection rules onto alert summaries, we uncovered a need to allow rule types to specify a custom format function for the alerts returned from the getSummarizedAlerts function. This will allow detection rules to perform some custom transformations before detection alerts are made available for notifications. This PR adds the necessary hook that can be used later on.

@ymao1 ymao1 force-pushed the alerting/format-alerts-hook branch from aade7db to 6cf32dc Compare February 10, 2023 04:26
@ymao1 ymao1 force-pushed the alerting/format-alerts-hook branch from 6cf32dc to fd928bc Compare February 10, 2023 04:28
@ymao1 ymao1 changed the title Adding hook for formatting alerts to get alert summary function [Response Ops][Alerting] Adding ability for rule types to specify custom formatting for getSummarizedAlerts function Feb 13, 2023
@ymao1 ymao1 self-assigned this Feb 13, 2023
@ymao1 ymao1 added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0 labels Feb 13, 2023
@ymao1 ymao1 marked this pull request as ready for review February 13, 2023 18:01
@ymao1 ymao1 requested review from a team as code owners February 13, 2023 18:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

Copy link
Contributor

@doakalexi doakalexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ymao1 ymao1 merged commit 6bd55da into elastic:main Feb 13, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 13, 2023
@ymao1 ymao1 deleted the alerting/format-alerts-hook branch February 13, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Response Ops][Alerting] Add ability to specify custom format function when getting summarized alerts
5 participants