[SharedUX] Add custom branding to ExitFullScreenButton #150620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majagrubic
changed the title
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
majagrubic
changed the title
majagrubic
added
v8.8.0
release_note:skip
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
rshen91
approved these changes
Feb 13, 2023
| @@ -103,6 +104,16 @@ describe('<ExitFullScreenButton />', () => { | |||
| expect(kibanaServices.coreStart.chrome.setIsVisible).toHaveBeenCalledTimes(0); | |||
| }); | |||
|
|
|||
| test('renders custom logo', () => { | |||
ThomThomson
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the Elastic logo with the custom logo in
ExitFullScreenButtoncomponent.Without custom logo:
With custom logo:
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list- [ ] This was checked for cross-browser compatibilityFor maintainers