[serverless] split serverless config files #150616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
clintandrewhall
approved these changes
Feb 8, 2023
rayafratkina
added
the
Project:Serverless
spalger
force-pushed
the
implement/serverless-config
branch
2 times, most recently
from
7236568
to
ffb1863
Compare
spalger
commented
Feb 8, 2023
|
|
||
| configuration is applied in the following order, later values override | ||
| 1. kibana.yml | ||
| 2. serverless.yml |
There was a problem hiding this comment.
@clintandrewhall FYI, I tried the serverless/all.yml etc idea and unfortunately git has some weird restriction that prevents the .gitignores from working correctly.
spalger
force-pushed
the
implement/serverless-config
branch
2 times, most recently
from
8ecee2f
to
4b0b615
Compare
spalger
force-pushed
the
implement/serverless-config
branch
from
4b0b615
to
b576b95
Compare
|
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.7.0
backport:skip
This was referenced Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently expecting serverless environments to be broken up into several different envs, this config structure allows us to customize the config based on that environment without major modifications to the config loading system.