[Cloud Posture] add tests for findings flyout toggling #150551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orouz
added
release_note:skip
orouz
commented
Feb 8, 2023
| @@ -19,21 +19,40 @@ const chance = new Chance(); | |||
| type TableProps = PropsOf<typeof FindingsTable>; | |||
|
|
|||
| describe('<FindingsTable />', () => { | |||
| it('renders the zero state when status success and data has a length of zero ', async () => { | |||
| const renderWrapper = (opts?: Partial<TableProps>) => { | |||
There was a problem hiding this comment.
added this to simplify all tests in file
| @@ -66,23 +75,12 @@ describe('<FindingsTable />', () => { | |||
|
|
|||
| it('adds filter with a cell button click', () => { | |||
| const names = chance.unique(chance.sentence, 10); | |||
| const data = names.map(getFindingsFixture); | |||
There was a problem hiding this comment.
getFindingsFixture doesn't take any arguments so we're not using the unique names anymore. this used fail on CI because sometimes our tests would find identical strings. changed this to include unique rule names
| it('opens/closes the flyout when clicked on expand/close buttons ', () => { | ||
| renderWrapper({ items: [getFindingsFixture()] }); | ||
|
|
||
| expect(screen.queryByTestId('findings_flyout')).not.toBeInTheDocument(); |
There was a problem hiding this comment.
turns out we need to use queryByTestId and not getByTestId for .not stuff because it throws.
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
JordanSh
approved these changes
Feb 14, 2023
x-pack/plugins/cloud_security_posture/public/pages/findings/findings_flyout/findings_flyout.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/cloud_security_posture/public/pages/findings/layout/findings_layout.tsx
Outdated
Show resolved
Hide resolved
.../cloud_security_posture/public/pages/findings/latest_findings/latest_findings_table.test.tsx
Outdated
Show resolved
Hide resolved
orouz
force-pushed
the
csp_findings_flyout_toggle_test
branch
from
505619b to
f1791d3
Compare
orouz
force-pushed
the
csp_findings_flyout_toggle_test
branch
from
b6f2d07 to
5b647ee
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
opauloh
added
backport:prev-minor
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 23, 2023
(cherry picked from commit cfe91b1)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #140491
add a test case for checking visibility of flyout after toggling