[Fleet] refactor install registry and upload to extract common logic #150444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
the
release_note:skip
juliaElastic
force-pushed
the
upload-package-support
branch
from
f9b5330 to
e589f08
Compare
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
kpollich
approved these changes
Feb 7, 2023
kibanamachine
added
v8.7.0
backport:skip
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 8, 2023
* main: (187 commits) [APM] Removing the icon for tech preview and fixing some of the alert badges (elastic#150528) [Cloud Posture][Bug]added fix for resource tab + small css fix on CSPM onboarding (elastic#149997) Making maxTransactionGroupsExceeded false by default (elastic#150458) [Fleet] refactor install registry and upload to extract common logic (elastic#150444) [ftr tests] split x-pack functional_with_es_ssl config (elastic#150416) [APM] switch get environment function to use terms_enum api (elastic#150175) [Unified search] Fixes ally issues (elastic#150411) [Synthetics] Fix overview status query (elastic#150285) [api-docs] 2023-02-08 Daily api_docs build (elastic#150518) [canvas] Run tests against @kbn/handlebars compileAST function (elastic#150439) [RAM] Bring flapping status and settings in o11y (elastic#150483) [data view mgmt] fix field refresh when index pattern is changed. (elastic#150403) [RAM] Allow alert table to show new alert status on apm (elastic#150500) [Synthetics] errors - adjust empty state content (elastic#150455) Uncomment tests (elastic#150481) [TIP] fix broken cypress tests after change made in cases plugin (elastic#150479) [enterprise search]: disallow removing last index from engine (elastic#150464) [Security Solution][Exceptions] Rule exceptions TTL - Expiration (elastic#145180) Adds link to Jan 2023 contributors newsletter. (elastic#150259) [Security Solution][Alerts] Fix bug when suppression has both created and updated alerts (elastic#150236) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #148599
Closes #82007
Factored out common logic in
installPackageFromRegistryandinstallPackageByUploadto a new function. This improves the upload flow as well to handle install failure.We might want to introduce a
forceflag for the upload API to reinstall a package, now the logic does not do anything if the installed version package is uploaded again.EDIT: found here that upload should work with an implicit
forceflag, so will update that.More manual and automated tests needed.
Checklist