Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add feature flag for FQDN toggle #150441

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Feb 7, 2023

Part of #149059

Add a feature flag which will remove the hostname toggle from the UI if we need to remove it at the last minute (e.g the agent work doesn't make it into 8.7)

@hop-dev hop-dev added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Feb 7, 2023
@hop-dev hop-dev self-assigned this Feb 7, 2023
@hop-dev hop-dev requested a review from a team as a code owner February 7, 2023 15:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 I guess we do not want the API to be behind the feature flag?

@hop-dev
Copy link
Contributor Author

hop-dev commented Feb 7, 2023

🚀 I guess we do not want the API to be behind the feature flag?

I thought about this, but the API & docs are just a generic list of feature flags they don't mention FQDN so I thought we could leave it

@hop-dev hop-dev enabled auto-merge (squash) February 7, 2023 15:18
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 927.1KB 927.1KB +31.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 121.8KB 121.8KB +17.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

@hop-dev hop-dev merged commit 8870891 into elastic:main Feb 7, 2023
@kibanamachine kibanamachine added v8.7.0 backport:skip This commit does not require backporting labels Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants