Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified search] Fixes ally issues #150411

Merged
merged 1 commit into from
Feb 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@ class PhraseValueInputUI extends PhraseSuggestorUI<PhraseValueInputProps> {
id: 'unifiedSearch.filter.filterEditor.valueSelectPlaceholder',
defaultMessage: 'Select a value',
})}
aria-label={intl.formatMessage({
id: 'unifiedSearch.filter.filterEditor.valueSelectPlaceholder',
defaultMessage: 'Select a value',
})}
options={options}
getLabel={(option) => option}
selectedOptions={value ? [valueAsStr] : []}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ class PhrasesValuesInputUI extends PhraseSuggestorUI<PhrasesValuesInputProps> {
id: 'unifiedSearch.filter.filterEditor.valuesSelectPlaceholder',
defaultMessage: 'Select values',
})}
aria-label={intl.formatMessage({
id: 'unifiedSearch.filter.filterEditor.valuesSelectPlaceholder',
defaultMessage: 'Select values',
})}
delimiter=","
isCaseSensitive={true}
options={options}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ class ValueInputTypeUI extends Component<Props> {
disabled={this.props.disabled}
fullWidth={this.props.fullWidth}
placeholder={this.props.placeholder}
aria-label={this.props.placeholder}
value={value}
onChange={this.onChange}
isInvalid={!validateParams(value, this.props.field)}
Expand All @@ -67,6 +68,7 @@ class ValueInputTypeUI extends Component<Props> {
disabled={this.props.disabled}
fullWidth={this.props.fullWidth}
placeholder={this.props.placeholder}
aria-label={this.props.placeholder}
value={this.getValueForNumberField(value)}
onChange={this.onChange}
controlOnly={this.props.controlOnly}
Expand All @@ -83,6 +85,7 @@ class ValueInputTypeUI extends Component<Props> {
disabled={this.props.disabled}
fullWidth={this.props.fullWidth}
placeholder={this.props.placeholder}
aria-label={this.props.placeholder}
value={value}
onChange={this.onChange}
onBlur={this.onBlur}
Expand All @@ -100,6 +103,7 @@ class ValueInputTypeUI extends Component<Props> {
fullWidth={this.props.fullWidth}
disabled={this.props.disabled}
placeholder={this.props.placeholder}
aria-label={this.props.placeholder}
value={value}
onChange={this.onChange}
isInvalid={!isEmpty(value) && !validateParams(value, this.props.field)}
Expand Down Expand Up @@ -132,6 +136,7 @@ class ValueInputTypeUI extends Component<Props> {
]}
value={value}
onChange={this.onBoolChange}
aria-label={this.props.placeholder}
className={this.props.className}
fullWidth={this.props.fullWidth}
compressed={this.props.compressed}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export function FieldInput({ field, dataView, onHandleField }: FieldInputProps)
placeholder={strings.getFieldSelectPlaceholderLabel()}
sortMatchesBy="startsWith"
singleSelection={{ asPlainText: true }}
aria-label={strings.getFieldSelectPlaceholderLabel()}
isClearable={false}
compressed
fullWidth
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ export function FilterItem({
})}
>
<EuiFlexItem
role="button"
grow={false}
aria-label={strings.getDragFilterAriaLabel()}
{...provided.dragHandleProps}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ export function OperatorInput<TParams = unknown>({
compressed
isDisabled={!field || disabled}
placeholder={strings.getOperatorSelectPlaceholderSelectLabel()}
aria-label={strings.getOperatorSelectPlaceholderSelectLabel()}
options={operators}
selectedOptions={operator ? [operator] : []}
getLabel={({ message }) => message}
Expand Down