Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AO] Improve loading state in Overview page #150327

Merged

Conversation

maryam-saeidi
Copy link
Member

@maryam-saeidi maryam-saeidi commented Feb 6, 2023

Fixes #150305

Summary

This PR fixes the loading state of the infra_metrics section.

I also tried to check why the Log section appears without any loading state but it seems the API that returns if this section has data takes a bit more time than the other APIs (@weltenwort please let me know if my assumption is not correct or if you have suggestion about how to get the hasData info for Log section quicker)

Before After
image image

@maryam-saeidi maryam-saeidi self-assigned this Feb 6, 2023
@maryam-saeidi maryam-saeidi added release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" labels Feb 6, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 511 512 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 582.8KB 583.4KB +600.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

@maryam-saeidi maryam-saeidi marked this pull request as ready for review February 6, 2023 14:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@maryam-saeidi maryam-saeidi requested a review from a team February 6, 2023 14:46
@weltenwort
Copy link
Member

weltenwort commented Feb 7, 2023

💭 I don't know about the other APIs but I don't see a way right now to perform the "has data" check for logs faster. The performance is mainly determined by the time it takes to instantiate the data view data structure. #139340 would allow us to speed that up once implemented.

Copy link
Contributor

@CoenWarmer CoenWarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maryam-saeidi maryam-saeidi merged commit c5dfeba into elastic:main Feb 8, 2023
@maryam-saeidi maryam-saeidi deleted the 150305-improve-overview-loading branch February 8, 2023 11:51
@kibanamachine kibanamachine added v8.7.0 backport:skip This commit does not require backporting labels Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AO] Improve loading state of observability overview page
6 participants