[Cases] Break long titles in toaster #150257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
release_note:skip
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
cnasikas
added
the
backport:prev-minor
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @cnasikas |
jonathan-buttner
approved these changes
Feb 6, 2023
js-jankisalvi
approved these changes
Feb 6, 2023
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Feb 7, 2023
## Summary In some toasters, the title of the toaster is set from user input. It is possible for long titles to overflow the toaster. This PR fixes this issue by forcing long titles to break. Uses the EUI CSS utility class `eui-textBreakWord`. Fixes: elastic#149485 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit ce6bde1) # Conflicts: # x-pack/plugins/cases/public/components/actions/assignees/use_assignees_action.test.tsx # x-pack/plugins/cases/public/components/actions/copy_id/use_copy_id_action.test.tsx # x-pack/plugins/cases/public/components/actions/use_items_action.test.tsx
cnasikas
added a commit
that referenced
this pull request
Feb 7, 2023
# Backport This will backport the following commits from `main` to `8.6`: - [[Cases] Break long titles in toaster (#150257)](#150257) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Christos Nasikas","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-07T12:26:56Z","message":"[Cases] Break long titles in toaster (#150257)\n\n## Summary\r\n\r\nIn some toasters, the title of the toaster is set from user input. It is\r\npossible for long titles to overflow the toaster. This PR fixes this\r\nissue by forcing long titles to break. Uses the EUI CSS utility class\r\n`eui-textBreakWord`.\r\n\r\nFixes: https://github.com/elastic/kibana/issues/149485\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"ce6bde172b605133a01055f8498a09e34ad70ce1","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Cases","backport:prev-minor","v8.7.0"],"number":150257,"url":"https://github.com/elastic/kibana/pull/150257","mergeCommit":{"message":"[Cases] Break long titles in toaster (#150257)\n\n## Summary\r\n\r\nIn some toasters, the title of the toaster is set from user input. It is\r\npossible for long titles to overflow the toaster. This PR fixes this\r\nissue by forcing long titles to break. Uses the EUI CSS utility class\r\n`eui-textBreakWord`.\r\n\r\nFixes: https://github.com/elastic/kibana/issues/149485\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"ce6bde172b605133a01055f8498a09e34ad70ce1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150257","number":150257,"mergeCommit":{"message":"[Cases] Break long titles in toaster (#150257)\n\n## Summary\r\n\r\nIn some toasters, the title of the toaster is set from user input. It is\r\npossible for long titles to overflow the toaster. This PR fixes this\r\nissue by forcing long titles to break. Uses the EUI CSS utility class\r\n`eui-textBreakWord`.\r\n\r\nFixes: https://github.com/elastic/kibana/issues/149485\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"ce6bde172b605133a01055f8498a09e34ad70ce1"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In some toasters, the title of the toaster is set from user input. It is possible for long titles to overflow the toaster. This PR fixes this issue by forcing long titles to break. Uses the EUI CSS utility class
eui-textBreakWord.Fixes: #149485
Checklist
Delete any items that are not applicable to this PR.
For maintainers