Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Make spaces plugin optional #150252

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Feb 3, 2023

Summary

This PR makes the spaces plugin an optional dependency for the cases plugin.

Related: #149687

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature labels Feb 3, 2023
@cnasikas cnasikas self-assigned this Feb 3, 2023
@cnasikas cnasikas requested a review from thomheymann February 3, 2023 14:18
@cnasikas cnasikas marked this pull request as ready for review February 3, 2023 14:22
@cnasikas cnasikas requested a review from a team as a code owner February 3, 2023 14:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@cnasikas cnasikas added the release_note:skip Skip the PR/issue when compiling release notes label Feb 4, 2023
@cnasikas
Copy link
Member Author

cnasikas commented Feb 6, 2023

@elasticmachine merge upstream

logger: loggingSystemMock.createLogger(),
});

// @ts-expect-error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some text explaining what the error would be?

@cnasikas cnasikas added the v8.8.0 label Feb 9, 2023
@cnasikas cnasikas enabled auto-merge (squash) February 9, 2023 08:52
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

@cnasikas cnasikas merged commit 7981e47 into elastic:main Feb 9, 2023
@cnasikas cnasikas deleted the spaces_optional branch February 9, 2023 09:31
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants