Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.6] [@kbn/handlebars] Add support for partials (#150151) #150223

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.6:

Questions ?

Please refer to the Backport tool documentation

Add support for [partials](https://handlebarsjs.com/guide/partials.html)
to our own implementation of the [handlebars](https://handlebarsjs.com)
template engine.

Closes elastic#139068

(cherry picked from commit 2b82cb7)
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Documentation preview:

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/handlebars 12 14 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.0MB 1.0MB +2.1KB
uiActionsEnhanced 138.8KB 140.9KB +2.1KB
visTypeTimeseries 511.6KB 513.7KB +2.1KB
total +6.2KB
Unknown metric groups

API count

id before after diff
@kbn/handlebars 19 21 +2

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
@kbn/handlebars 4 5 +1
enterpriseSearch 19 21 +2
fleet 61 67 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +20

Total ESLint disabled count

id before after diff
@kbn/handlebars 8 9 +1
enterpriseSearch 20 22 +2
fleet 69 75 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @watson

@kibanamachine kibanamachine merged commit 0659916 into elastic:8.6 Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants