Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Fix flaky alertsList test #150122

Merged
merged 5 commits into from
Feb 8, 2023
Merged

[RAM] Fix flaky alertsList test #150122

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa42caf
Fix alertsList refresh function in test
Zacqary Feb 1, 2023
e5830a6
Fix notify_when case
Zacqary Feb 2, 2023
57312a2
Merge branch 'main' into 131535-fix-alertlist-test
kibanamachine Feb 6, 2023
90c5ec2
Merge branch 'main' into 131535-fix-alertlist-test
kibanamachine Feb 8, 2023
f1d6910
Merge branch 'main' into 131535-fix-alertlist-test
kibanamachine Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts_list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
const objectRemover = new ObjectRemover(supertest);

async function refreshAlertsList() {
await testSubjects.click('logsTab');
await testSubjects.click('rulesTab');
}

// FLAKY: https://github.com/elastic/kibana/issues/131535
describe.skip('rules list', function () {
describe('rules list', function () {
const assertRulesLength = async (length: number) => {
return await retry.try(async () => {
const rules = await pageObjects.triggersActionsUI.getAlertsList();
Expand Down Expand Up @@ -495,7 +495,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
params: { level: 'info', message: 'gfghfhg' },
frequency: {
summary: false,
notifyWhen: 'onActionGroupChange',
notify_when: 'onActionGroupChange',
throttle: null,
},
},
Expand Down Expand Up @@ -676,7 +676,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
params: { level: 'info', message: 'gfghfhg' },
frequency: {
summary: false,
notifyWhen: 'onActionGroupChange',
notify_when: 'onActionGroupChange',
throttle: null,
},
},
Expand Down