Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark spaces as optional on the contracts #150021

Merged
merged 4 commits into from
Feb 2, 2023
Merged

Mark spaces as optional on the contracts #150021

merged 4 commits into from
Feb 2, 2023

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Feb 1, 2023 •
edited
Loading

Summary

Part of #149687

Lens defines the space plugin as optional. I am fixing the types here in order to be also optional on the contract.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #45 / Fleet Endpoints EPM Endpoints EPM - get allows user with only package level permission to access corresponding packages

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This commit does not require backporting Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 1, 2023
@thomheymann thomheymann mentioned this pull request Feb 1, 2023
Closed
@stratoula stratoula marked this pull request as ready for review February 2, 2023 07:32
@stratoula stratoula requested a review from a team as a code owner February 2, 2023 07:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

nickofthyme
nickofthyme approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@stratoula stratoula merged commit b161749 into elastic:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stratoula @kibana-ci @elasticmachine @nickofthyme @kibanamachine