Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ftr] split alerting_api_integration/spaces_only/config.ts into small fast configs #149854

Merged
merged 14 commits into from
Feb 1, 2023
Merged

[ftr] split alerting_api_integration/spaces_only/config.ts into small fast configs #149854

merged 14 commits into from
Feb 1, 2023

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Jan 30, 2023 •
edited by kibanamachine
Loading

Summary

Trying to address slow config issue:

The following "Functional Tests" configs have durations that exceed the maximum amount of time desired for a single CI job. This is not an error, and if you don't own any of these configs then you can ignore this warning.If you own any of these configs please split them up ASAP and ask Operations if you have questions about how to do that.

x-pack/test/alerting_api_integration/spaces_only/config.ts: 41.4 minutes

by splitting it into multiple groups.

1 round (splitting main index file with 3 index suites where each one has its own setup/tearDown + alerting suite into 4 groups)
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group1/config.ts 7m 1s
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/config.ts 15m 10s
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group3/config.ts 21m 40s
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group4/config.ts 5m 30s
x-pack/test/alerting_api_integration/spaces_only/tests/action_task_params/config.ts 2m 31s
x-pack/test/alerting_api_integration/spaces_only/tests/actions/config.ts 4m 22s

2 round (rebalance groups 1-4 to be more time equal)
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group1/config.ts 12m 46s
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/config.ts 8m 46s
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group3/config.ts 17m 30s
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group4/config.ts 9m 5s

Here Alerting eventLog alerts should generate expected alert events for normal operation test started to fail, probably there is a dependency on the previous tests.

3 round (rebalance groups 1-4, to keep tests order in group 1 up until event_log.ts suite)
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group1/config.ts 17m 12s
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/config.ts 8m 28s
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group3/config.ts 16m 15s
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group4/config.ts 6m 21s

4 round (rebalancing groups 3-4 to be more time equal)
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group1/config.ts 17m 14s
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/config.ts 8m 37s
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group3/config.ts 12m 40s
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group4/config.ts 9m 49s

@dmlemeshko dmlemeshko force-pushed the split-alerting-api-integration-config branch from 2faeee8 to b91f850 Compare January 31, 2023 15:24
@dmlemeshko dmlemeshko changed the title [ftr] split config in 3 groups [ftr] split alerting_api_integration/spaces_only/config.ts into small fast configs Jan 31, 2023
@dmlemeshko dmlemeshko added the release_note:skip Skip the PR/issue when compiling release notes label Feb 1, 2023
@dmlemeshko dmlemeshko marked this pull request as ready for review February 1, 2023 10:49
@dmlemeshko dmlemeshko requested review from a team as code owners February 1, 2023 10:49
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #33 / Fleet Endpoints Fleet Endpoints fleet_list_agent should return metrics if available and called with withMetrics

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ymao1
ymao1 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

spalger
spalger approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@dmlemeshko dmlemeshko merged commit 71a2bf9 into elastic:main Feb 1, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.6 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 149854

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 2, 2023
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this pull request Feb 6, 2023
@dmlemeshko @kibanamachine @kqualters-elastic
[ftr] split alerting_api_integration/spaces_only/config.ts into sma…
1ec49d2 
…ll fast configs (elastic#149854)

## Summary

Trying to address slow config issue:

```
The following "Functional Tests" configs have durations that exceed the maximum amount of time desired for a single CI job. This is not an error, and if you don't own any of these configs then you can ignore this warning.If you own any of these configs please split them up ASAP and ask Operations if you have questions about how to do that.

x-pack/test/alerting_api_integration/spaces_only/config.ts: 41.4 minutes
```

by splitting it into multiple groups.

_1 round (splitting main index file with 3 index suites where each one
has its own setup/tearDown + alerting suite into 4 groups)_

x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group1/config.ts
7m 1s

x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/config.ts
**15m 10s**

x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group3/config.ts
**21m 40s**

x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group4/config.ts
5m 30s

x-pack/test/alerting_api_integration/spaces_only/tests/action_task_params/config.ts
2m 31s

x-pack/test/alerting_api_integration/spaces_only/tests/actions/config.ts
4m 22s

_2 round (rebalance groups 1-4 to be more time equal)_

x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group1/config.ts
12m 46s

x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/config.ts
8m 46s

x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group3/config.ts
17m 30s

x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group4/config.ts
9m 5s

Here `Alerting eventLog alerts should generate expected alert events for
normal operation` test started to fail, probably there is a dependency
on the previous tests.

_3 round (rebalance groups 1-4, to keep tests order in group 1 up until
`event_log.ts` suite)_

x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group1/config.ts
17m 12s

x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/config.ts
8m 28s

x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group3/config.ts
16m 15s

x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group4/config.ts
6m 21s

_4 round (rebalancing groups 3-4 to be more time equal)_

x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group1/config.ts
**17m 14s**

x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/config.ts
**8m 37s**

x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group3/config.ts
**12m 40s**

x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group4/config.ts
**9m 49s**

---------

Co-authored-by: kibanamachine <[email protected]>
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

@dmlemeshko dmlemeshko deleted the split-alerting-api-integration-config branch November 21, 2023 12:20
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

15 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 149854 locally

@jbudz jbudz added the backport:skip This commit does not require backporting label Sep 30, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.6.2 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dmlemeshko @kibana-ci @kibanamachine @spalger @ymao1 @jbudz