chore(slo): Improve fixtures and storybook cases #149639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdelemme
added
release_note:skip
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
kdelemme
force-pushed
the
chore/slo-fixtures
branch
from
0686fe1 to
6cd5d91
Compare
maryam-saeidi
approved these changes
Jan 30, 2023
| @@ -8,7 +8,7 @@ | |||
| import React from 'react'; | |||
| import { ComponentStory } from '@storybook/react'; | |||
|
|
|||
| import { anSLO } from '../../../data/slo/slo'; | |||
| import { buildSlo } from '../../../data/slo/slo'; | |||
There was a problem hiding this comment.
slo/slo Thats why I like index :D
|
|
||
| export const buildOccurrencesObjective = ( | ||
| params: Partial<SLOWithSummaryResponse['objective']> = {} | ||
| ): SLOWithSummaryResponse['objective'] => { |
There was a problem hiding this comment.
Do I understand correctly that this is a io-ts type? And will typescript use it as a return type?
There was a problem hiding this comment.
SLOWithSummaryResponse is actually a t.OutputOf<typeof some-io-ts-schema> which becomes a proper TS type.
CoenWarmer
approved these changes
Jan 30, 2023
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @kdelemme |
kqualters-elastic
pushed a commit
to kqualters-elastic/kibana
that referenced
this pull request
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Resolves #148077
This PR introduces better SLO fixtures for the frontend. I've also added more storybook cases for catching regression on more slo definition cases.
No behaviours have changed.