unskip test/functional/apps/maps/group4/discover·js #149554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
@elasticmachine merge upstream |
nickpeihl
approved these changes
Jan 26, 2023
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kqualters-elastic
pushed a commit
to kqualters-elastic/kibana
that referenced
this pull request
Feb 6, 2023
Fixes elastic#137408 and elastic#149358 flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1790 Tests flaky because clicking on `Visualize` button not registered. This resulted in test failing because the test started looking for elements in Maps even though the page was still in Discover. PR resolves flakiness by adding retry around click to ensure `Visualize` button is clicked as expected. Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137408 and #149358
flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1790
Tests flaky because clicking on
Visualizebutton not registered. This resulted in test failing because the test started looking for elements in Maps even though the page was still in Discover. PR resolves flakiness by adding retry around click to ensureVisualizebutton is clicked as expected.