[Cloud Posture] CIS AWS - Multi-dashboards links and labels #148941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanSh
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
orouz
approved these changes
Jan 15, 2023
...ud_security_posture/public/pages/compliance_dashboard/dashboard_sections/summary_section.tsx
Show resolved
Hide resolved
| }); | ||
| }; | ||
|
|
||
| const handleViewAllClick = (clusterId: string) => { | ||
| navToFindings({ cluster_id: clusterId, 'result.evaluation': RULE_FAILED }); | ||
| navToFindings({ | ||
| cluster_id: clusterId, |
There was a problem hiding this comment.
is cluster_id relevant for CSPM? @CohenIdo
There was a problem hiding this comment.
there will be cluster ids and account ids in cspm, but until we actually know whats going on here, we rely on cluster id for now
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @JordanSh |
kibanamachine
added
v8.7.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #146590
benchmark.idiscis_awsFor now, we will not split the dashboards completely, the only difference ATM is just some labels, we decided that its better to keep it simple for now and replace those labels where its needed