[RAM] Add error for action interval shorter than check interval

[Zacqary]

Summary

Closes #148569

Adds form error and API error for action intervals shorter than rule check intervals

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Unit or functional tests were updated or added to match the most common scenarios

[Zacqary]

@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/response-ops (Team:ResponseOps)

[XavierM]

@Zacqary are you sure that's the right ticket #148659?

[XavierM]

Question: Should we fail all the actions if one failed this validation? or should we allow the persistence of the other actions? what do you think?

[Zacqary]

validateActions is used to validate API requests. It would be more confusing for the user if their update or create request only applied 2 out of 3 of the actions they wanted it to, as opposed to just throwing an error and asking them to send the whole request again.

[XavierM]

ok make sense but can we validate all the actions at once so we can return a fully detailed msg with the ruleId and ruleName, so they do not have to call it each time to figure out what's wrong in one step.

[Zacqary]

This would be a larger change that modifies part of validateActions out of scope for #148569. Can you create a new issue with a full spec for what you'd like error messages to look like and I can tackle that in another PR?

[XavierM]

Ok I will!

[Zacqary]

@XavierM We don't currently have API integration tests for any other inner workings of Rules Client methods. These changes are covered in the additions to create.test.ts. The alerting_api_integration suite only tests if the API receives and responds to requests, and I don't think we should start asking it to duplicate the functionality of the Rules Client jest tests and give us redundant tests to maintain.

[Zacqary]

@XavierM: I think the error msg should be gone in this case, I am having a hard time to reproduce it now.

Fixed in e76abc8

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: fd25d4b

Failed CI Steps

• Security Solution Tests #4

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
triggersActionsUi	707.7KB	709.0KB	+1.4KB

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
triggersActionsUi	116	115	-1

Total ESLint disabled count

id	before	after	diff
triggersActionsUi	119	118	-1

History

• 💛 Build #100897 was flaky a0682ab
• 💔 Build #100817 failed 1d312e8
• 💔 Build #100292 failed 1a31173
• 💔 Build #100261 failed c861121
• 💔 Build #100254 failed 2317be8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[XavierM]

LGTM, #149415 for a follow up PR