Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Alert Summaries] Add default summary message #148749

Merged
merged 21 commits into from
Feb 2, 2023

Conversation

doakalexi
Copy link
Contributor

@doakalexi doakalexi commented Jan 11, 2023

Resolves #148537

Summary

Added the capability for rule types to provide a default message for summary actions. This default message gets pre-populated within the rule action form whenever a user adds an action to a rule.

Also added a default framework summary message.

Checklist

To verify

  • Create a rule and add an action and select notify on custom action intervals
  • Verify that the default message is populated
The system has detected {{alerts.new.count}} new, {{alerts.ongoing.count}} ongoing, and {{alerts.recovered.count}} alerts.

@doakalexi doakalexi changed the title Adding default summary message [ResponseOps][Alert Summaries] Add default summary message Jan 11, 2023
@doakalexi doakalexi added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) release_note:feature Makes this part of the condensed release notes labels Jan 11, 2023
@doakalexi doakalexi marked this pull request as ready for review January 11, 2023 20:10
@doakalexi doakalexi requested a review from a team as a code owner January 11, 2023 20:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@doakalexi doakalexi requested a review from a team as a code owner January 31, 2023 13:24
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

limits.yml

Copy link
Contributor

@ersin-erdal ersin-erdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Added a couple of comments.

Copy link
Contributor

@ersin-erdal ersin-erdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doakalexi doakalexi enabled auto-merge (squash) February 2, 2023 20:47
@doakalexi doakalexi merged commit f90bf81 into elastic:main Feb 2, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
triggersActionsUi 560 561 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 749.6KB 749.9KB +278.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 115.7KB 118.4KB +2.7KB
Unknown metric groups

API count

id before after diff
triggersActionsUi 589 590 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added v8.7.0 backport:skip This commit does not require backporting labels Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Alert Summaries] Add default summary message
6 participants