Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Do not allow namespace or dataset to be edited for input only package policies #148737

Merged

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Jan 11, 2023

Summary

Part of #145529.

Input packages will create component and index templates on package policy creation. These changes make it so that to change the namespace or dataset of an input only package the user must create a new package policy, this is because by changing these the user is sending the data to a new destination which semantically is a different policy.

Screenshot 2023-01-04 at 21 05 15

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 910.8KB 911.2KB +486.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 121.7KB 121.7KB +37.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@hop-dev hop-dev marked this pull request as ready for review January 11, 2023 18:36
@hop-dev hop-dev requested a review from a team as a code owner January 11, 2023 18:36
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jan 11, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kpollich kpollich added the release_note:skip Skip the PR/issue when compiling release notes label Jan 11, 2023
@kpollich kpollich merged commit ed71baf into elastic:main Jan 11, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 11, 2023
jennypavlova pushed a commit to jennypavlova/kibana that referenced this pull request Jan 13, 2023
… package policies (elastic#148737)

## Summary

Part of elastic#145529.

Input packages will create component and index templates on package
policy creation. These changes make it so that to change the namespace
or dataset of an input only package the user must create a new package
policy, this is because by changing these the user is sending the data
to a new destination which semantically is a different policy.

<img width="674" alt="Screenshot 2023-01-04 at 21 05 15"
src="https://user-images.githubusercontent.com/3315046/210650968-79460ff4-dd52-47bd-beb6-a0ace608bcbb.png">

Co-authored-by: Kyle Pollich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants