-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Do not allow namespace or dataset to be edited for input only package policies #148737
Merged
kpollich
merged 20 commits into
elastic:main
from
hop-dev:145529-lock-namespace-and-dataset-input-pkgs
Jan 11, 2023
Merged
[Fleet] Do not allow namespace or dataset to be edited for input only package policies #148737
kpollich
merged 20 commits into
elastic:main
from
hop-dev:145529-lock-namespace-and-dataset-input-pkgs
Jan 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kyle Pollich <[email protected]>
This reverts commit ee94f32.
This reverts commit 1e9a41f.
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kpollich
approved these changes
Jan 11, 2023
botelastic
bot
added
the
Team:Fleet
Team label for Observability Data Collection Fleet team
label
Jan 11, 2023
Pinging @elastic/fleet (Team:Fleet) |
kpollich
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Jan 11, 2023
jennypavlova
pushed a commit
to jennypavlova/kibana
that referenced
this pull request
Jan 13, 2023
… package policies (elastic#148737) ## Summary Part of elastic#145529. Input packages will create component and index templates on package policy creation. These changes make it so that to change the namespace or dataset of an input only package the user must create a new package policy, this is because by changing these the user is sending the data to a new destination which semantically is a different policy. <img width="674" alt="Screenshot 2023-01-04 at 21 05 15" src="https://user-images.githubusercontent.com/3315046/210650968-79460ff4-dd52-47bd-beb6-a0ace608bcbb.png"> Co-authored-by: Kyle Pollich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v8.7.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #145529.
Input packages will create component and index templates on package policy creation. These changes make it so that to change the namespace or dataset of an input only package the user must create a new package policy, this is because by changing these the user is sending the data to a new destination which semantically is a different policy.