-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken test by updating test certs #148733
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson
added
release_note:skip
Skip the PR/issue when compiling release notes
v8.7.0
v8.6.1
v8.5.4
v7.17.9
labels
Jan 11, 2023
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @watson |
azasypkin
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 11, 2023
(cherry picked from commit afbdfa5)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 11, 2023
(cherry picked from commit afbdfa5)
This was referenced Jan 11, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 11, 2023
(cherry picked from commit afbdfa5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 11, 2023
# Backport This will backport the following commits from `main` to `8.6`: - [Fix broken test by updating test certs (#148733)](#148733) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Thomas Watson","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-01-11T17:12:44Z","message":"Fix broken test by updating test certs (#148733)","sha":"afbdfa51127ee0f274ff69acb7995d3b6c57526a","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.7.0","v8.6.1","v8.5.4","v7.17.9"],"number":148733,"url":"https://github.com/elastic/kibana/pull/148733","mergeCommit":{"message":"Fix broken test by updating test certs (#148733)","sha":"afbdfa51127ee0f274ff69acb7995d3b6c57526a"}},"sourceBranch":"main","suggestedTargetBranches":["8.6","8.5","7.17"],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/148733","number":148733,"mergeCommit":{"message":"Fix broken test by updating test certs (#148733)","sha":"afbdfa51127ee0f274ff69acb7995d3b6c57526a"}},{"branch":"8.6","label":"v8.6.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.5","label":"v8.5.4","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"7.17","label":"v7.17.9","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Thomas Watson <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jan 11, 2023
# Backport This will backport the following commits from `main` to `7.17`: - [Fix broken test by updating test certs (#148733)](#148733) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Thomas Watson","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-01-11T17:12:44Z","message":"Fix broken test by updating test certs (#148733)","sha":"afbdfa51127ee0f274ff69acb7995d3b6c57526a","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.7.0","v8.6.1","v8.5.4","v7.17.9"],"number":148733,"url":"https://github.com/elastic/kibana/pull/148733","mergeCommit":{"message":"Fix broken test by updating test certs (#148733)","sha":"afbdfa51127ee0f274ff69acb7995d3b6c57526a"}},"sourceBranch":"main","suggestedTargetBranches":["8.6","8.5","7.17"],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/148733","number":148733,"mergeCommit":{"message":"Fix broken test by updating test certs (#148733)","sha":"afbdfa51127ee0f274ff69acb7995d3b6c57526a"}},{"branch":"8.6","label":"v8.6.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.5","label":"v8.5.4","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"7.17","label":"v7.17.9","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Thomas Watson <[email protected]>
jennypavlova
pushed a commit
to jennypavlova/kibana
that referenced
this pull request
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The the localhost certificate inside of
localhost.p12
had expired. I re-generated all certs as it was easier.Fixes #148515