[Dashboard] Un-skip Show Underlying Data Tests #148409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomThomson
added
Feature:Dashboard
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
stratoula
approved these changes
Jan 10, 2023
kibanamachine
added
v8.7.0
backport:skip
jennypavlova
pushed a commit
to jennypavlova/kibana
that referenced
this pull request
Jan 13, 2023
Fix tracking of refresh interval setting in dashboard state unskip show underlying data tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #147625.
Flaky test runner
When the dashboard was
saved aswithout creating a copy, the set state from save modal reducer erroneously set the time range and time restore to undefined, when they should have just been left as-is. This PR fixes that, and unskips the test that was failing because of it.This PR also introduces some changes to the refresh interval setting, which removes some slight flakiness from the
dashboard view edit modeand solves some inconsistent behaviour. These changes include: