Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnifiedFieldList] Persist field list sections state in local storage #148373

Merged
merged 6 commits into from
Jan 5, 2023

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Jan 4, 2023

Part of #137779

Summary

This PR uses localStorage to persist which list sections user prefers to expand/collapse per app (discover and lens state is saved separately).

Screenshot 2023-01-04 at 12 26 16

Checklist

@jughosta jughosta added release_note:enhancement backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:UnifiedFieldList The unified field list component used by Lens & Discover v8.7.0 labels Jan 4, 2023
@jughosta jughosta self-assigned this Jan 4, 2023
@jughosta jughosta marked this pull request as ready for review January 4, 2023 14:37
@jughosta jughosta requested review from a team as code owners January 4, 2023 14:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled and tested locally, LGTM!

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx, this works great. Visualizations team changes LGTM

@jughosta jughosta enabled auto-merge (squash) January 5, 2023 11:10
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
unifiedFieldList 83 86 +3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
unifiedFieldList 244 245 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 395.9KB 395.9KB +33.0B
lens 1.3MB 1.3MB +58.0B
unifiedFieldList 48.3KB 50.6KB +2.3KB
total +2.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
unifiedFieldList 36.5KB 36.5KB +49.0B
Unknown metric groups

API count

id before after diff
unifiedFieldList 269 270 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta merged commit 19fd0c1 into elastic:main Jan 5, 2023
@jughosta jughosta deleted the sidebar-sections-to-local-storage branch January 5, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:UnifiedFieldList The unified field list component used by Lens & Discover release_note:enhancement Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants