Fix broken date range look #14837
Merged
Fix broken date range look #14837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
Team:Platform-Design
timroes
requested review from
lukasolson,
cjcenizal,
thomasneirynck and
ppisljar
|
the PR this is fixing #11980 is talking about a broken link not broken styles ? |
timroes
changed the title
ppisljar
approved these changes
Nov 8, 2017
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Nov 10, 2017
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the broken date range look as described in #12731Sorry I missread there. This issue fixes the broken date range look (that wasn't described in #12731, but was visible there in the screenshot).
The
kbn-timepickerclasses have always been on these elements, but PR #11980 now applieddisplay: flexto them thus destroying the defaultdisplay: table-cellwhich was needed for the styling. I checked, that thesekbn-timepickerclasses haven't set any other styling on that element or any child elements, and are not used in tests, so they can safely be removed from the date range table cells to fix this bug.UPDATE: This actually doesn't fix #12731 (which I misread), this fixes the broken styling, that can be seen in #12731. The issue itself is already fixed by #14630