-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ResponseOps] Add intermediate status info to outcomeMsg of Rule lastRun #148142
Closed
jpdjere
wants to merge
4
commits into
elastic:main
from
jpdjere:intermediate-status-as-outcomeMsg-in-last-run
Closed
[ResponseOps] Add intermediate status info to outcomeMsg of Rule lastRun #148142
jpdjere
wants to merge
4
commits into
elastic:main
from
jpdjere:intermediate-status-as-outcomeMsg-in-last-run
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Merged
2 tasks
Closing this one since we don't need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modify the
lastRunFromState
function fromx-pack/plugins/alerting/server/lib/last_run_status.ts
, which takes metrics produced during Rule Execution, as well as results produced during execution by theRuleResultService
, so that now:warnings
produced in the Solution side by theRuleResultService
are added to theoutcomeMsg
array.errors
produced in the Solution side by theRuleResultService
are added to theoutcomeMsg
array.Checklist
Delete any items that are not applicable to this PR.