[ML] Move local storage utilities to package. #148049
Conversation
walterra
force-pushed
the
ml-package-storage
branch
from
e968adf
to
19faca0
Compare
walterra
force-pushed
the
ml-package-storage
branch
from
8093d7e
to
a5080a8
Compare
walterra
force-pushed
the
ml-package-storage
branch
from
9989ef9
to
eea9870
Compare
walterra
added
:ml
backport:skip
|
Pinging @elastic/ml-ui (:ml) |
walterra
requested review from
alvarezmelissa87
and removed request for
qn895
| @@ -5,4 +5,4 @@ | |||
| * 2.0. | |||
| */ | |||
|
|
|||
| export { MlStorageContextProvider, useStorage } from './storage_context'; | |||
| export { isDefined } from './src/is_defined'; | |||
There was a problem hiding this comment.
Could you add a comment to this exported function to keep the 'public APIs without comments' count at 0?
| storageKeys: readonly K[]; | ||
| } | ||
|
|
||
| export function StorageContextProvider<K extends TStorageKey, T extends TStorage>({ |
There was a problem hiding this comment.
Could you add a comment to this to keep the 'public APIs without comments' count at 0 for this package.
| removeValue: <K extends TStorageKey>(key: K) => void; | ||
| } | ||
|
|
||
| export function isStorageKey<T>(key: unknown, storageKeys: readonly T[]): key is T { |
There was a problem hiding this comment.
Could you add a comment to this to keep the 'public APIs without comments' count at 0 for this package.
| return storageKeys.includes(key as T); | ||
| } | ||
|
|
||
| export const MlStorageContext = React.createContext<StorageAPI>({ |
There was a problem hiding this comment.
Could you add a comment to this to keep the 'public APIs without comments' count at 0 for this package.
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: cc @walterra |
Summary
Part of #136182.
Follow up to #147912.
Moves multiple copies of
useStorage()and related code to a package as a single source. The different copies with hard coded types have been adapted souseStorage()is now based on generics. Also moves duplicates ofisDefined()to its own package.Some duplicate settings related to
FROZEN_TIER_PREFERENCEremain, this will be deduplicated in the follow up in #148063.