Ensure that API keys are rendered before performing bulk delete in functional tests. #148013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
test
Team:Security
|
Pinging @elastic/kibana-security (Team:Security) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
azasypkin
added a commit
to azasypkin/kibana
that referenced
this pull request
Dec 23, 2022
…nctional tests. (elastic#148013) (cherry picked from commit 3a5f562) # Conflicts: # x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_grid_page.test.tsx # x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_grid_page.tsx # x-pack/test/functional/apps/api_keys/home_page.ts # x-pack/test/functional/page_objects/api_keys_page.ts
azasypkin
added a commit
to azasypkin/kibana
that referenced
this pull request
Dec 23, 2022
…nctional tests. (elastic#148013) (cherry picked from commit 3a5f562) # Conflicts: # x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_grid_page.test.tsx # x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_grid_page.tsx # x-pack/test/functional/apps/api_keys/home_page.ts # x-pack/test/functional/page_objects/api_keys_page.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
azasypkin
added a commit
that referenced
this pull request
Dec 23, 2022
… in functional tests. (#148013) (#148044) # Backport This will backport the following commits from `main` to `8.6`: - [Ensure that API keys are rendered before performing bulk delete in functional tests. (#148013)](#148013) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Aleh Zasypkin","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-22T18:44:11Z","message":"Ensure that API keys are rendered before performing bulk delete in functional tests. (#148013)","sha":"3a5f5626b2c3631eb2646782937171d2f87ce525","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","Team:Security","Feature:Users/Roles/API Keys","release_note:skip","ci:no-auto-commit","backport:all-open","v8.7.0"],"number":148013,"url":"https://github.com/elastic/kibana/pull/148013","mergeCommit":{"message":"Ensure that API keys are rendered before performing bulk delete in functional tests. (#148013)","sha":"3a5f5626b2c3631eb2646782937171d2f87ce525"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/148013","number":148013,"mergeCommit":{"message":"Ensure that API keys are rendered before performing bulk delete in functional tests. (#148013)","sha":"3a5f5626b2c3631eb2646782937171d2f87ce525"}}]}] BACKPORT-->
azasypkin
added a commit
that referenced
this pull request
Dec 23, 2022
… in functional tests. (#148013) (#148045) # Backport This will backport the following commits from `main` to `8.5`: - [Ensure that API keys are rendered before performing bulk delete in functional tests. (#148013)](#148013) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Aleh Zasypkin","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-22T18:44:11Z","message":"Ensure that API keys are rendered before performing bulk delete in functional tests. (#148013)","sha":"3a5f5626b2c3631eb2646782937171d2f87ce525","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","Team:Security","Feature:Users/Roles/API Keys","release_note:skip","ci:no-auto-commit","backport:all-open","v8.7.0"],"number":148013,"url":"https://github.com/elastic/kibana/pull/148013","mergeCommit":{"message":"Ensure that API keys are rendered before performing bulk delete in functional tests. (#148013)","sha":"3a5f5626b2c3631eb2646782937171d2f87ce525"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/148013","number":148013,"mergeCommit":{"message":"Ensure that API keys are rendered before performing bulk delete in functional tests. (#148013)","sha":"3a5f5626b2c3631eb2646782937171d2f87ce525"}}]}] BACKPORT-->
azasypkin
added a commit
that referenced
this pull request
Dec 23, 2022
…e in functional tests. (#148013) (#148047) # Backport This will backport the following commits from `main` to `7.17`: - [Ensure that API keys are rendered before performing bulk delete in functional tests. (#148013)](#148013) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Aleh Zasypkin","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-22T18:44:11Z","message":"Ensure that API keys are rendered before performing bulk delete in functional tests. (#148013)","sha":"3a5f5626b2c3631eb2646782937171d2f87ce525","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","Team:Security","Feature:Users/Roles/API Keys","release_note:skip","ci:no-auto-commit","backport:all-open","v8.7.0"],"number":148013,"url":"https://github.com/elastic/kibana/pull/148013","mergeCommit":{"message":"Ensure that API keys are rendered before performing bulk delete in functional tests. (#148013)","sha":"3a5f5626b2c3631eb2646782937171d2f87ce525"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/148013","number":148013,"mergeCommit":{"message":"Ensure that API keys are rendered before performing bulk delete in functional tests. (#148013)","sha":"3a5f5626b2c3631eb2646782937171d2f87ce525"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on the logs and screenshot from failed test runs, the test was able to perform all required actions, but didn't manage to bulk delete all the keys. The last created key (
api key 2) was still in the API keys grid after bulk delete.My assumption is that it took quite some time for the last added key to appear in the grid so that the bulk delete action didn't affect it. In this PR I'm making sure that both created keys are rendered before the test tries to delete them in bulk.
Flaky Test Runner: ✔️ 1673 (x50)
Fixes: #141868