Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Actionable Observability] - Add latency alert history chart on the Alert details page for APM #148011
[Actionable Observability] - Add latency alert history chart on the Alert details page for APM #148011
Changes from 44 commits
df3845d
14f0479
85f9fd2
a5cdacd
9af2eb6
9e3bfd1
88fefb0
5fef281
974239a
7f069c8
6d8c450
af617d4
9cd4977
1f29c83
918fa23
24e586f
f759f2f
2937e31
efc5ec0
727aeae
30fc534
88d7a2f
1f40dab
24aa28d
731a954
e149baf
973b842
a915154
a951d02
3c81c91
d6340ef
d88e530
6460159
09250d3
7765438
b24a081
d227c53
9989f48
8c91323
cb63134
63712af
d95a8f8
eefaa4c
2412cf4
fbe3293
c1a5647
ef6d66d
b8d79d9
ef7431d
f852882
67ec170
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why wouldn't you want to rerun the function when
latencyAggregationType
changes?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CoenWarmer For this part, I'm just following how APM has implemented it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, maybe @sqren knows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall.
@cauemarcondes Afaict you implemented this initially in https://github.com/elastic/kibana/pull/84634/files#diff-f615240301482e0d4e5d73f0ccd406fea462cd7493e857c0f5225e3b61dcd1c0R70.